Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-17 Thread haosdent huang 


> On June 17, 2016, 5:39 p.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, line 459
> > 
> >
> > s/associate/associated/
> > 
> > i'll fix this while committing.

Thanks a lot!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review138260
---


On June 17, 2016, 1:28 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> ---
> 
> (Updated June 17, 2016, 1:28 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> ---
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review138260
---


Ship it!





src/tests/api_tests.cpp (line 459)


s/associate/associated/

i'll fix this while committing.



src/tests/api_tests.cpp (line 479)


s/an unscheduled machine/unscheduled machines/

i'll fix this while committing.



src/tests/api_tests.cpp (line 531)


extra "//".

i'll fix this while committing.


- Vinod Kone


On June 17, 2016, 1:28 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> ---
> 
> (Updated June 17, 2016, 1:28 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> ---
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review138148
---



Patch looks great!

Reviews applied: [48115, 48116, 48257, 48084, 48259, 48260, 48285, 48286, 48580]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 1:28 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> ---
> 
> (Updated June 17, 2016, 1:28 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> ---
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/
---

(Updated June 17, 2016, 1:28 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5507
https://issues.apache.org/jira/browse/MESOS-5507


Repository: mesos


Description
---

Added test case `MasterAPITest.StartAndStopMaintenance`.


Diffs (updated)
-

  src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 

Diff: https://reviews.apache.org/r/48580/diff/


Testing
---

Test by

```
./bin/mesos-tests.sh --gtest_filter="*APITest*"
```


Thanks,

haosdent huang

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review137200
---



Patch looks great!

Reviews applied: [48115, 48116, 48257, 48084, 48259, 48260, 48285, 48286, 48580]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 12, 2016, 5:47 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> ---
> 
> (Updated June 12, 2016, 5:47 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> ---
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/
---

(Updated June 12, 2016, 5:47 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5507
https://issues.apache.org/jira/browse/MESOS-5507


Repository: mesos


Description
---

Added test case `MasterAPITest.StartAndStopMaintenance`.


Diffs (updated)
-

  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48580/diff/


Testing
---

Test by

```
./bin/mesos-tests.sh --gtest_filter="*APITest*"
```


Thanks,

haosdent huang

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review137114
---



Patch looks great!

Reviews applied: [48115, 48116, 48257, 48084, 48259, 48260, 48285, 48286, 48580]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 11, 2016, 9:27 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> ---
> 
> (Updated June 11, 2016, 9:27 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> ---
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

2016-06-11 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/
---

Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-5507
https://issues.apache.org/jira/browse/MESOS-5507


Repository: mesos


Description
---

Added test case `MasterAPITest.StartAndStopMaintenance`.


Diffs
-

  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48580/diff/


Testing
---

Test by

```
./bin/mesos-tests.sh --gtest_filter="*APITest*"
```


Thanks,

haosdent huang