Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/#review167328 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On June 29, 2016, 4:57 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48581/ > --- > > (Updated June 29, 2016, 4:57 p.m.) > > > Review request for mesos, Benjamin Mahler and Joris Van Remoortere. > > > Bugs: MESOS-5234 > https://issues.apache.org/jira/browse/MESOS-5234 > > > Repository: mesos > > > Description > --- > > Removed duplicated code in 'strings::tokenize()'. > > > Diffs > - > > 3rdparty/stout/include/stout/strings.hpp > 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 > > > Diff: https://reviews.apache.org/r/48581/diff/1/ > > > Testing > --- > > make && make check > > > Thanks, > > Klaus Ma > >
Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/ --- (Updated June 30, 2016, 12:57 a.m.) Review request for mesos, Benjamin Mahler and Joris Van Remoortere. Changes --- Add Joris as reviewers Bugs: MESOS-5234 https://issues.apache.org/jira/browse/MESOS-5234 Repository: mesos Description --- Removed duplicated code in 'strings::tokenize()'. Diffs - 3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing --- make && make check Thanks, Klaus Ma
Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/#review137115 --- Patch looks great! Reviews applied: [46425, 48581] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 11, 2016, 11 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48581/ > --- > > (Updated June 11, 2016, 11 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Removed duplicated code in 'strings::tokenize()'. > > > Diffs > - > > 3rdparty/stout/include/stout/strings.hpp > 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 > > Diff: https://reviews.apache.org/r/48581/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Klaus Ma > >
Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/ --- (Updated June 11, 2016, 7 p.m.) Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Removed duplicated code in 'strings::tokenize()'. Diffs - 3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing (updated) --- make && make check Thanks, Klaus Ma
Review Request 48581: Removed duplicated code in 'strings::tokenize()'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48581/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Removed duplicated code in 'strings::tokenize()'. Diffs - 3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing --- Thanks, Klaus Ma
