Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-21 Thread haosdent huang 


> On June 21, 2016, 9:45 p.m., Anand Mazumdar wrote:
> > src/slave/http.cpp, line 620
> > 
> >
> > hmm.. We forgot evolving the response here?

My bad when rebasing this chain, post a follow patch at 
https://reviews.apache.org/r/49056/ Thank you very much for pointing out this. 
:-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review138948
---


On June 16, 2016, 5:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 16, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-21 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review138948
---




src/slave/http.cpp (line 620)


hmm.. We forgot evolving the response here?


- Anand Mazumdar


On June 16, 2016, 5:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 16, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review138064
---



Patch looks great!

Reviews applied: [48583, 48584, 48585, 48799, 48587, 48588, 48800, 48595, 
48737, 48596, 48597, 48600, 48601, 48602, 48603]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 5:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 16, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-16 Thread haosdent huang 


> On June 16, 2016, 10:03 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [48603, 48602, 48601, 48600, 48597, 48596, 48737, 48595, 
> > 48588, 48587, 48585, 48584, 48583]
> > 
> > Failed command: ./support/apply-review.sh -n -r 48601
> > 
> > Error:
> > 2016-06-16 10:03:55 URL:https://reviews.apache.org/r/48601/diff/raw/ 
> > [9056/9056] -> "48601.patch" [1]
> > 3rdparty/libprocess/src/metrics/metrics.cpp:232:  Lines should be <= 80 
> > characters long  [whitespace/line_length] [2]
> > Total errors found: 1
> > Checking 2 files
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/13814/console
> 
> Vinod Kone wrote:
> can you fix this @haosdent?

Oh, just fixed.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137950
---


On June 16, 2016, 5:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 16, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/
---

(Updated June 16, 2016, 5:26 p.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
Guo, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5484
https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
---

Implemented v1::agent::Call::GET_METRICS.


Diffs (updated)
-

  src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
  src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48603/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-16 Thread Vinod Kone 


> On June 16, 2016, 10:03 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [48603, 48602, 48601, 48600, 48597, 48596, 48737, 48595, 
> > 48588, 48587, 48585, 48584, 48583]
> > 
> > Failed command: ./support/apply-review.sh -n -r 48601
> > 
> > Error:
> > 2016-06-16 10:03:55 URL:https://reviews.apache.org/r/48601/diff/raw/ 
> > [9056/9056] -> "48601.patch" [1]
> > 3rdparty/libprocess/src/metrics/metrics.cpp:232:  Lines should be <= 80 
> > characters long  [whitespace/line_length] [2]
> > Total errors found: 1
> > Checking 2 files
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/13814/console

can you fix this @haosdent?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137950
---


On June 15, 2016, 4:28 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 15, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137950
---



Bad patch!

Reviews applied: [48603, 48602, 48601, 48600, 48597, 48596, 48737, 48595, 
48588, 48587, 48585, 48584, 48583]

Failed command: ./support/apply-review.sh -n -r 48601

Error:
2016-06-16 10:03:55 URL:https://reviews.apache.org/r/48601/diff/raw/ 
[9056/9056] -> "48601.patch" [1]
3rdparty/libprocess/src/metrics/metrics.cpp:232:  Lines should be <= 80 
characters long  [whitespace/line_length] [2]
Total errors found: 1
Checking 2 files

Full log: https://builds.apache.org/job/mesos-reviewbot/13814/console

- Mesos ReviewBot


On June 15, 2016, 4:28 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 15, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137899
---


Ship it!




Ship It!

- Vinod Kone


On June 15, 2016, 4:28 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 15, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/
---

(Updated June 15, 2016, 4:28 p.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
Guo, and Vinod Kone.


Changes
---

Address @vinodkone's comment.


Bugs: MESOS-5484
https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
---

Implemented v1::agent::Call::GET_METRICS.


Diffs (updated)
-

  src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
  src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48603/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/
---

(Updated June 15, 2016, 2:51 p.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
Guo, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5484
https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
---

Implemented v1::agent::Call::GET_METRICS.


Diffs (updated)
-

  src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
  src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
  src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48603/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/
---

(Updated June 15, 2016, 2:31 p.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
Guo, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5484
https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
---

Implemented v1::agent::Call::GET_METRICS.


Diffs (updated)
-

  src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
  src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
  src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48603/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-14 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137608
---



same comments as previous review.

- Vinod Kone


On June 12, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 12, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
>   src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137187
---



Patch looks great!

Reviews applied: [48583, 48584, 48585, 48587, 48588, 48595, 48596, 48597, 
48600, 48601, 48602, 48603]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 12, 2016, 6:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 12, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
>   src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/
---

(Updated June 12, 2016, 6:04 p.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
Guo, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5484
https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
---

Implemented v1::agent::Call::GET_METRICS.


Diffs (updated)
-

  src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
  src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
  src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48603/diff/


Testing
---


Thanks,

haosdent huang

Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

2016-06-12 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/
---

Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.


Bugs: MESOS-5484
https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
---

Implemented v1::agent::Call::GET_METRICS.


Diffs
-

  src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
  src/slave/http.cpp 67ad7a92195abc266fd82fa5dc4c71f24a02aef3 
  src/slave/slave.hpp da8b0d78af8611d22d66935e908e14977b242586 
  src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 

Diff: https://reviews.apache.org/r/48603/diff/


Testing
---


Thanks,

haosdent huang