Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-30 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/#review140237
---


Ship it!




Here is a suggestion for a more descriptive commit message:

```
Added a flag for excluding resources from fair sharing.

The intention of this flag is for the operator to specify
resources types (e.g. "cpus", "mem", "gpus", etc) that should
not be fairly shared.

The implementation of will not count the specified resources
towards a role's share of the cluster. This may be useful in
cases where our fair sharing implementation currently has
limitations. E.g. See the problem of "scarce" resources:

http://www.mail-archive.com/dev@mesos.apache.org/msg35631.html
https://issues.apache.org/jira/browse/MESOS-5377
```


src/master/flags.cpp (lines 436 - 438)


Hm.. the user doesn't know about sorters, how about this suggestion, which 
is a bit more high level:

```
+  add(::fair_sharing_excluded_resource_names,
+  "fair_sharing_excluded_resource_names",
+  "A comma-separated list of the resource names (e.g. 'gpus')\n"
+  "that will be excluded from fair sharing constraints.\n"
+  "This may be useful in cases where the fair sharing\n"
+  "implementation currently has limitations. E.g. See the\n"
+  "problem of \"scarce\" resources:\n"
+  "  http://www.mail-archive.com/dev@mesos.apache.org/msg35631.html\n;
+  "  https://issues.apache.org/jira/browse/MESOS-5377;);
```


- Benjamin Mahler


On June 30, 2016, 7:51 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48895/
> ---
> 
> (Updated June 30, 2016, 7:51 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5620
> https://issues.apache.org/jira/browse/MESOS-5620
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator_fairness_excluded_resource_names flag to master.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
>   src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 
> 
> Diff: https://reviews.apache.org/r/48895/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-30 Thread Klaus Ma 


> On June 30, 2016, 1:01 a.m., Klaus Ma wrote:
> > src/master/flags.cpp, line 437
> > 
> >
> > s/client/framework
> > 
> > Mesos user does not know client.
> 
> Guangya Liu wrote:
> I think that here not only framework, but also roles, I will udpate it to 
> 
> "A comma-separated list of the resource names that will be ignored\n"
> "by WDRF sorter when calculating share for clients (frameworks or 
> roles).\n");

Only the code reader known what's `clients` means in sorter, we did not need to 
expose it to end user; using `framework/roles` directly is better.


- Klaus


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/#review140011
---


On June 30, 2016, 3:51 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48895/
> ---
> 
> (Updated June 30, 2016, 3:51 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5620
> https://issues.apache.org/jira/browse/MESOS-5620
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator_fairness_excluded_resource_names flag to master.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
>   src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 
> 
> Diff: https://reviews.apache.org/r/48895/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-30 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/
---

(Updated 六月 30, 2016, 7:51 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5620
https://issues.apache.org/jira/browse/MESOS-5620


Repository: mesos


Description
---

Added allocator_fairness_excluded_resource_names flag to master.


Diffs (updated)
-

  src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
  src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 

Diff: https://reviews.apache.org/r/48895/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-30 Thread Guangya Liu 


> On 六月 29, 2016, 5:01 p.m., Klaus Ma wrote:
> > src/master/flags.cpp, line 437
> > 
> >
> > s/client/framework
> > 
> > Mesos user does not know client.

I think that here not only framework, but also roles, I will udpate it to 

"A comma-separated list of the resource names that will be ignored\n"
"by WDRF sorter when calculating share for clients (frameworks or roles).\n");


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/#review140011
---


On 六月 30, 2016, 2:26 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48895/
> ---
> 
> (Updated 六月 30, 2016, 2:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5620
> https://issues.apache.org/jira/browse/MESOS-5620
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator_fairness_excluded_resource_names flag to master.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
>   src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 
> 
> Diff: https://reviews.apache.org/r/48895/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-29 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/
---

(Updated 六月 30, 2016, 2:26 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5620
https://issues.apache.org/jira/browse/MESOS-5620


Repository: mesos


Description
---

Added allocator_fairness_excluded_resource_names flag to master.


Diffs (updated)
-

  src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
  src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 

Diff: https://reviews.apache.org/r/48895/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-29 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/#review140011
---




src/master/flags.cpp (line 437)


s/client/framework

Mesos user does not know client.


- Klaus Ma


On June 29, 2016, 8:14 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48895/
> ---
> 
> (Updated June 29, 2016, 8:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5620
> https://issues.apache.org/jira/browse/MESOS-5620
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added allocator_fairness_excluded_resource_names flag to master.
> 
> 
> Diffs
> -
> 
>   src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
>   src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 
> 
> Diff: https://reviews.apache.org/r/48895/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-29 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/
---

(Updated 六月 29, 2016, 12:14 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5620
https://issues.apache.org/jira/browse/MESOS-5620


Repository: mesos


Description
---

Added allocator_fairness_excluded_resource_names flag to master.


Diffs (updated)
-

  src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
  src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 

Diff: https://reviews.apache.org/r/48895/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/
---

(Updated 六月 24, 2016, 9:31 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5620
https://issues.apache.org/jira/browse/MESOS-5620


Repository: mesos


Description
---

Added allocator_fairness_excluded_resource_names flag to master.


Diffs (updated)
-

  src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
  src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 

Diff: https://reviews.apache.org/r/48895/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48895/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-5620
https://issues.apache.org/jira/browse/MESOS-5620


Repository: mesos


Description
---

Added allocator_fairness_excluded_resource_names flag to master.


Diffs
-

  src/master/flags.hpp 735367ff5412d611f4eae6cb63dd4829c4338002 
  src/master/flags.cpp b6b1603f02d3c6f861edad3de770ecb3fcad0057 

Diff: https://reviews.apache.org/r/48895/diff/


Testing
---

make
make check


Thanks,

Guangya Liu