Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49390/
---

(Updated July 1, 2016, 5 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, 
Artem Harutyunyan, Jie Yu, and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5727
https://issues.apache.org/jira/browse/MESOS-5727


Repository: mesos


Description
---

Added test for container image command task with health check.


Diffs (updated)
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/49390/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49390/#review140463
---


Ship it!




Ship It!

- Jie Yu


On July 1, 2016, 11:34 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49390/
> ---
> 
> (Updated July 1, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, 
> Artem Harutyunyan, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5727
> https://issues.apache.org/jira/browse/MESOS-5727
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for container image command task with health check.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/49390/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49390/
---

(Updated July 1, 2016, 4:34 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, 
Artem Harutyunyan, Jie Yu, and Vinod Kone.


Bugs: MESOS-5727
https://issues.apache.org/jira/browse/MESOS-5727


Repository: mesos


Description
---

Added test for container image command task with health check.


Diffs (updated)
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/49390/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49390/#review140453
---




src/tests/health_check_tests.cpp (line 309)


I would rename this to ROOT_HealtyTaskWithContainerImage



src/tests/health_check_tests.cpp (lines 383 - 385)


Why we need reconciliation here?


- Jie Yu


On July 1, 2016, 9:54 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49390/
> ---
> 
> (Updated July 1, 2016, 9:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, 
> Artem Harutyunyan, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-5727
> https://issues.apache.org/jira/browse/MESOS-5727
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for container image command task with health check.
> 
> 
> Diffs
> -
> 
>   src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 
> 
> Diff: https://reviews.apache.org/r/49390/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 49390: Added test for container image command task with health check.

2016-07-01 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49390/
---

(Updated July 1, 2016, 2:54 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Mahler, haosdent huang, 
Artem Harutyunyan, Jie Yu, and Vinod Kone.


Bugs: MESOS-5727
https://issues.apache.org/jira/browse/MESOS-5727


Repository: mesos


Description
---

Added test for container image command task with health check.


Diffs (updated)
-

  src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb 

Diff: https://reviews.apache.org/r/49390/diff/


Testing (updated)
---

make check


Thanks,

Gilbert Song