Re: Review Request 49500: Moved TODO to correct place in master/http.cpp.

2016-07-01 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49500/#review140401
---




src/master/http.cpp (lines 3102 - 3139)


can you rebase. the logic of `tasks()` and `getTasks()` has been changed on 
trunk.


- Vinod Kone


On July 1, 2016, 9:36 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49500/
> ---
> 
> (Updated July 1, 2016, 9:36 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved TODO to correct place in master/http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 670b4e0e4424400d138fdf4ca1493520c90b6448 
> 
> Diff: https://reviews.apache.org/r/49500/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 49500: Moved TODO to correct place in master/http.cpp.

2016-07-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49500/#review140333
---



Bad patch!

Reviews applied: [49500, 49370, 49369]

Failed command: ./support/apply-review.sh -n -r 49369

Error:
2016-07-01 11:05:43 URL:https://reviews.apache.org/r/49369/diff/raw/ 
[18082/18082] -> "49369.patch" [1]
error: patch failed: include/mesos/authorizer/acls.proto:293
error: include/mesos/authorizer/acls.proto: patch does not apply
error: patch failed: src/common/http.hpp:136
error: src/common/http.hpp: patch does not apply
error: patch failed: src/tests/master_authorization_tests.cpp:1691
error: src/tests/master_authorization_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14064/console

- Mesos ReviewBot


On July 1, 2016, 9:36 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49500/
> ---
> 
> (Updated July 1, 2016, 9:36 a.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved TODO to correct place in master/http.cpp.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 670b4e0e4424400d138fdf4ca1493520c90b6448 
> 
> Diff: https://reviews.apache.org/r/49500/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 49500: Moved TODO to correct place in master/http.cpp.

2016-07-01 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49500/
---

Review request for mesos, Adam B and Vinod Kone.


Repository: mesos


Description
---

Moved TODO to correct place in master/http.cpp.


Diffs
-

  src/master/http.cpp 670b4e0e4424400d138fdf4ca1493520c90b6448 

Diff: https://reviews.apache.org/r/49500/diff/


Testing
---


Thanks,

Joerg Schad