Re: Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/#review140603 --- Patch looks great! Reviews applied: [49581, 49582] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 4, 2016, 12:39 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49582/ > --- > > (Updated July 4, 2016, 12:39 a.m.) > > > Review request for mesos and Klaus Ma. > > > Bugs: MESOS-5692 > https://issues.apache.org/jira/browse/MESOS-5692 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/authentication/cram_md5/auxprop.cpp > 5912b01a80d30b5ad79d71b4a5041635ab8e1b84 > src/common/roles.cpp 65c71931a5645d346439c3cdff1c5c8cc3ee01a3 > src/slave/containerizer/fetcher.cpp > 15ff61ff54d72c951edbd591058ad04f8d1efb58 > > Diff: https://reviews.apache.org/r/49582/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Re: Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/#review140600 --- Ship it! Ship It! - Klaus Ma On July 4, 2016, 8:39 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49582/ > --- > > (Updated July 4, 2016, 8:39 a.m.) > > > Review request for mesos and Klaus Ma. > > > Bugs: MESOS-5692 > https://issues.apache.org/jira/browse/MESOS-5692 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/authentication/cram_md5/auxprop.cpp > 5912b01a80d30b5ad79d71b4a5041635ab8e1b84 > src/common/roles.cpp 65c71931a5645d346439c3cdff1c5c8cc3ee01a3 > src/slave/containerizer/fetcher.cpp > 15ff61ff54d72c951edbd591058ad04f8d1efb58 > > Diff: https://reviews.apache.org/r/49582/diff/ > > > Testing > --- > > `make check` > > > Thanks, > > Michael Park > >
Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/ --- Review request for mesos and Klaus Ma. Bugs: MESOS-5692 https://issues.apache.org/jira/browse/MESOS-5692 Repository: mesos Description --- See summary. Diffs - src/authentication/cram_md5/auxprop.cpp 5912b01a80d30b5ad79d71b4a5041635ab8e1b84 src/common/roles.cpp 65c71931a5645d346439c3cdff1c5c8cc3ee01a3 src/slave/containerizer/fetcher.cpp 15ff61ff54d72c951edbd591058ad04f8d1efb58 Diff: https://reviews.apache.org/r/49582/diff/ Testing --- `make check` Thanks, Michael Park
