Re: Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.
> On July 21, 2016, 7:05 p.m., Benjamin Mahler wrote: > > Ship It! Note that you have a typo in the commit summary. (paring -> parsing) - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50285/#review143128 --- On July 21, 2016, 6:52 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50285/ > --- > > (Updated July 21, 2016, 6:52 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Replaced boost::lexical_cast with numify when paring Value. > > > Diffs > - > > src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 > src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e > > Diff: https://reviews.apache.org/r/50285/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Klaus Ma > >
Re: Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50285/#review143128 --- Ship it! Ship It! - Benjamin Mahler On July 21, 2016, 6:52 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50285/ > --- > > (Updated July 21, 2016, 6:52 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > --- > > Replaced boost::lexical_cast with numify when paring Value. > > > Diffs > - > > src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 > src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e > > Diff: https://reviews.apache.org/r/50285/diff/ > > > Testing > --- > > make && make check > > > Thanks, > > Klaus Ma > >
Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50285/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description --- Replaced boost::lexical_cast with numify when paring Value. Diffs - src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 Diff: https://reviews.apache.org/r/50285/diff/ Testing --- make && make check Thanks, Klaus Ma
