Re: Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-28 Thread Tomasz Janiszewski 


> On July 28, 2016, 12:01 a.m., Vinod Kone wrote:
> > docs/getting-started.md, line 50
> > 
> >
> > what's libz needed for? we don't seem to install it in our docker 
> > builds? https://github.com/apache/mesos/blob/master/support/docker_build.sh

It looks like zlib is installed indirectly with other dependecies 
`libsvn-dev`,` libcurl4-nss-dev`. I double checkd it and `./configure` errors 
must be my fault.


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50398/#review143863
---


On July 25, 2016, 5:39 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50398/
> ---
> 
> (Updated July 25, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libz to Ubuntu build dependencies.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
> 
> Diff: https://reviews.apache.org/r/50398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-27 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50398/#review143863
---




docs/getting-started.md (line 50)


what's libz needed for? we don't seem to install it in our docker builds? 
https://github.com/apache/mesos/blob/master/support/docker_build.sh


- Vinod Kone


On July 25, 2016, 5:39 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50398/
> ---
> 
> (Updated July 25, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libz to Ubuntu build dependencies.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
> 
> Diff: https://reviews.apache.org/r/50398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-27 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50398/#review143862
---


Ship it!




Ship It!

- Vinod Kone


On July 25, 2016, 5:39 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50398/
> ---
> 
> (Updated July 25, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libz to Ubuntu build dependencies.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
> 
> Diff: https://reviews.apache.org/r/50398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50398/#review143411
---



Patch looks great!

Reviews applied: [50398]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 25, 2016, 5:39 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50398/
> ---
> 
> (Updated July 25, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libz to Ubuntu build dependencies.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
> 
> Diff: https://reviews.apache.org/r/50398/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-25 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50398/
---

Review request for mesos, Dave Lester, Kevin Klues, and Vinod Kone.


Repository: mesos


Description
---

Added libz to Ubuntu build dependencies.


Diffs
-

  docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 

Diff: https://reviews.apache.org/r/50398/diff/


Testing
---


Thanks,

Tomasz Janiszewski