Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.

2016-10-14 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50675/#review152750
---


Fix it, then Ship it!




I can fix the one test you missed.

---

Looks good!  On Windows:

>"3rdparty/stout/tests/Debug/stout_tests.exe"
```
[--] Global test environment tear-down
[==] 219 tests from 38 test cases ran. (4517 ms total)
[  PASSED  ] 219 tests.

  YOU HAVE 13 DISABLED TESTS
```

>"3rdparty/libprocess/src/tests/Debug/process_tests.exe"
```
[--] Global test environment tear-down
[==] 97 tests from 20 test cases ran. (767 ms total)
[  PASSED  ] 97 tests.

  YOU HAVE 44 DISABLED TESTS
```

---

Compared to OSX:

Stout:
```
[--] Global test environment tear-down
[==] 262 tests from 44 test cases ran. (425 ms total)
[  PASSED  ] 262 tests.
```

Libprocess:
```
[--] Global test environment tear-down
[==] 168 tests from 25 test cases ran. (645 ms total)
[  PASSED  ] 168 tests.

  YOU HAVE 2 DISABLED TESTS
```


3rdparty/libprocess/src/tests/process_tests.cpp (line 984)


Missed disabling this test.


- Joseph Wu


On Oct. 13, 2016, 6:10 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50675/
> ---
> 
> (Updated Oct. 13, 2016, 6:10 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A large number of libprocess test files are currently not being built on
> Windows. Many of these files contain tests for parts of libprocess that
> have already been ported, or require only trivial fixes to work (such as
> removing `#include`s on Windows). A small minority of the tests contain
> bugs that we should fix.
> 
> This commit will add these files to the build, fix some of the
> trivially-fixable tests, and disable tests that are known to fail
> because of bugs, including comments explaining why and links to JIRA
> issues where appropriate.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> c267117ab422310854d492493d711039b287d7e3 
>   3rdparty/libprocess/src/tests/future_tests.cpp 
> 383d260a4c0b17e9a0b5af002bb35070e3ec0b01 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 8d6c8c4507b93dd11f927bad2a8f0faeb957e388 
>   3rdparty/libprocess/src/tests/limiter_tests.cpp 
> 71a3d25d4040de9b0d3eb23612be80599f4b6a9a 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 88526e67a20b7b58a6e14034215faa3ae9879fd0 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 3936f47dfcacb0f85a6fa0f68f1707159b1c320c 
>   3rdparty/libprocess/src/tests/reap_tests.cpp 
> 586d52891af191d43229707c89a91cf9cbb9007d 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> c8350cf8e512dca23933725e6edb3e3d94380211 
>   3rdparty/libprocess/src/tests/time_tests.cpp 
> 9d40eaee046eaa43199bb92a54892207e9c31ef2 
> 
> Diff: https://reviews.apache.org/r/50675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.

2016-10-13 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50675/
---

(Updated Oct. 14, 2016, 1:10 a.m.)


Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
---

A large number of libprocess test files are currently not being built on
Windows. Many of these files contain tests for parts of libprocess that
have already been ported, or require only trivial fixes to work (such as
removing `#include`s on Windows). A small minority of the tests contain
bugs that we should fix.

This commit will add these files to the build, fix some of the
trivially-fixable tests, and disable tests that are known to fail
because of bugs, including comments explaining why and links to JIRA
issues where appropriate.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
c267117ab422310854d492493d711039b287d7e3 
  3rdparty/libprocess/src/tests/future_tests.cpp 
383d260a4c0b17e9a0b5af002bb35070e3ec0b01 
  3rdparty/libprocess/src/tests/http_tests.cpp 
8d6c8c4507b93dd11f927bad2a8f0faeb957e388 
  3rdparty/libprocess/src/tests/limiter_tests.cpp 
71a3d25d4040de9b0d3eb23612be80599f4b6a9a 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
88526e67a20b7b58a6e14034215faa3ae9879fd0 
  3rdparty/libprocess/src/tests/process_tests.cpp 
3936f47dfcacb0f85a6fa0f68f1707159b1c320c 
  3rdparty/libprocess/src/tests/reap_tests.cpp 
586d52891af191d43229707c89a91cf9cbb9007d 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
c8350cf8e512dca23933725e6edb3e3d94380211 
  3rdparty/libprocess/src/tests/time_tests.cpp 
9d40eaee046eaa43199bb92a54892207e9c31ef2 

Diff: https://reviews.apache.org/r/50675/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 50675: Libprocess: Enabled tests that pass on Windows.

2016-10-11 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50675/
---

(Updated Oct. 11, 2016, 11:49 p.m.)


Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
---

A large number of libprocess test files are currently not being built on
Windows. Many of these files contain tests for parts of libprocess that
have already been ported, or require only trivial fixes to work (such as
removing `#include`s on Windows). A small minority of the tests contain
bugs that we should fix.

This commit will add these files to the build, fix some of the
trivially-fixable tests, and disable tests that are known to fail
because of bugs, including comments explaining why and links to JIRA
issues where appropriate.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
c267117ab422310854d492493d711039b287d7e3 
  3rdparty/libprocess/src/tests/future_tests.cpp 
383d260a4c0b17e9a0b5af002bb35070e3ec0b01 
  3rdparty/libprocess/src/tests/http_tests.cpp 
8d6c8c4507b93dd11f927bad2a8f0faeb957e388 
  3rdparty/libprocess/src/tests/limiter_tests.cpp 
71a3d25d4040de9b0d3eb23612be80599f4b6a9a 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
88526e67a20b7b58a6e14034215faa3ae9879fd0 
  3rdparty/libprocess/src/tests/process_tests.cpp 
3936f47dfcacb0f85a6fa0f68f1707159b1c320c 
  3rdparty/libprocess/src/tests/time_tests.cpp 
9d40eaee046eaa43199bb92a54892207e9c31ef2 

Diff: https://reviews.apache.org/r/50675/diff/


Testing
---


Thanks,

Alex Clemmer

Review Request 50675: Libprocess: Enabled tests that pass on Windows.

2016-08-01 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50675/
---

Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
---

A large number of libprocess test files are currently not being built on
Windows. Many of these files contain tests for parts of libprocess that
have already been ported, or require only trivial fixes to work (such as
removing `#include`s on Windows). A small minority of the tests contain
bugs that we should fix.

This commit will add these files to the build, fix some of the
trivially-fixable tests, and disable tests that are known to fail
because of bugs, including comments explaining why and links to JIRA
issues where appropriate.


Diffs
-

  3rdparty/libprocess/src/tests/CMakeLists.txt 
c267117ab422310854d492493d711039b287d7e3 
  3rdparty/libprocess/src/tests/future_tests.cpp 
383d260a4c0b17e9a0b5af002bb35070e3ec0b01 
  3rdparty/libprocess/src/tests/http_tests.cpp 
8a0d61eb57f9ae972eedf3481f131844b283abc5 
  3rdparty/libprocess/src/tests/limiter_tests.cpp 
71a3d25d4040de9b0d3eb23612be80599f4b6a9a 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
5a82f4f49aecd03d12687de629516be5b7895036 
  3rdparty/libprocess/src/tests/process_tests.cpp 
54d9bbbd112668f27e572c38010cfab0707587a3 
  3rdparty/libprocess/src/tests/time_tests.cpp 
9d40eaee046eaa43199bb92a54892207e9c31ef2 

Diff: https://reviews.apache.org/r/50675/diff/


Testing
---


Thanks,

Alex Clemmer