Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/#review145398
---


Fix it, then Ship it!





src/health-check/health_checker.hpp 


This should stay as long as you keep the c-tor definition in the .hpp.



src/health-check/health_checker.hpp (line 25)


owned.hpp and time.hpp are missing, as well as stout/nothing.hpp



src/health-check/health_checker.hpp 


We usually declare the *Process class after the wrapper.



src/health-check/health_checker.hpp (lines 35 - 44)


We can move the c-tor definition to the .cpp as well.



src/health-check/health_checker.cpp (line 39)


According our style guide, the header should be included first.



src/health-check/health_checker.cpp (line 230)


Extra blank line.


- Alexander Rukletsov


On Aug. 9, 2016, 6:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50922/
> ---
> 
> (Updated Aug. 9, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the implementation of health check to health_checker.cpp.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/50922/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/#review145244
---



Patch looks great!

Reviews applied: [50922]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 6:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50922/
> ---
> 
> (Updated Aug. 9, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the implementation of health check to health_checker.cpp.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/50922/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

(Updated Aug. 9, 2016, 6:13 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/#review145214
---



Patch looks great!

Reviews applied: [50920, 50921, 50922]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 9, 2016, 10:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50922/
> ---
> 
> (Updated Aug. 9, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
> Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the implementation of health check to health_checker.cpp.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/50922/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

(Updated Aug. 9, 2016, 10:18 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Changes
---

Rebase.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs (updated)
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

(Updated Aug. 9, 2016, 9:17 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Changes
---

Fix compile error.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs (updated)
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang

Review Request 50922: Moved the implementation of health check to health_checker.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50922/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Gastón 
Kleiman.


Repository: mesos


Description
---

Moved the implementation of health check to health_checker.cpp.


Diffs
-

  src/health-check/health_checker.hpp b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
  src/health-check/health_checker.cpp 585a0b565d948cfa292bad818a710501a4ce0daf 

Diff: https://reviews.apache.org/r/50922/diff/


Testing
---


Thanks,

haosdent huang