Re: Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-09-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50958/#review147793
---




src/tests/uri_fetcher_tests.cpp (line 426)


have you run this test?


- Jie Yu


On Aug. 25, 2016, 3:22 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50958/
> ---
> 
> (Updated Aug. 25, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a test case for each of the existing fetcher plugins to
> invoke them by name.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 
> 
> Diff: https://reviews.apache.org/r/50958/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-09-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50958/#review147787
---


Fix it, then Ship it!




I did some tweek while committing. Please take a look


src/tests/uri_fetcher_tests.cpp (line 130)


2 lines apart



src/tests/uri_fetcher_tests.cpp (line 132)


CURL_InvokeFetchByName

Ditto below.



src/tests/uri_fetcher_tests.cpp (line 338)


INTERNET and CURL are test filters.


- Jie Yu


On Aug. 25, 2016, 3:22 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50958/
> ---
> 
> (Updated Aug. 25, 2016, 3:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a test case for each of the existing fetcher plugins to
> invoke them by name.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 
> 
> Diff: https://reviews.apache.org/r/50958/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-08-25 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50958/
---

(Updated Aug. 25, 2016, 3:22 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

Add a test case for each of the existing fetcher plugins to
invoke them by name.


Diffs (updated)
-

  src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 

Diff: https://reviews.apache.org/r/50958/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Review Request 50958: Added tests to invoke the fetcher plugins by name.

2016-08-10 Thread Srinivas Brahmaroutu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50958/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

Add a test case for each of the existing fetcher plugins to
invoke them by name.


Diffs
-

  src/tests/uri_fetcher_tests.cpp 072c09b8081e5d5dded907b1a0ffb6d739d86911 

Diff: https://reviews.apache.org/r/50958/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu