Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/#review167397
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 16, 2016, 5:58 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50959/
> ---
> 
> (Updated Oct. 16, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> AppcFetcherPlugin returns a '.aci' file of a container image.
> 
> Fetch supports all three modes that 'rkt fetch' supports, fetch with
> meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
> location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
> registry ex: 'docker://hello-world'.
> 
> Added new fetched plugin for Appc fetch algorithm. The new
> AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
> fetch a container image into a store specified at a directory location
> using 'rkt fetch' command and method 'rktExport' exports the image
> fetched into the directory location as a '.aci' file that is in tar
> file format, usinf 'rkt image export' command.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 
>   src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
>   src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
>   src/uri/fetchers/rkt.hpp PRE-CREATION 
>   src/uri/fetchers/rkt.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50959/diff/6/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

(Updated Oct. 16, 2016, 5:58 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location
using 'rkt fetch' command and method 'rktExport' exports the image
fetched into the directory location as a '.aci' file that is in tar
file format, usinf 'rkt image export' command.


Diffs (updated)
-

  src/Makefile.am 3bcc0f2dfc2c4f71841bd6d161f39e0e919fc0d7 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
  src/uri/fetchers/rkt.hpp PRE-CREATION 
  src/uri/fetchers/rkt.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

(Updated Sept. 19, 2016, 3:34 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location
using 'rkt fetch' command and method 'rktExport' exports the image
fetched into the directory location as a '.aci' file that is in tar
file format, usinf 'rkt image export' command.


Diffs (updated)
-

  src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
  src/uri/fetchers/rkt.hpp PRE-CREATION 
  src/uri/fetchers/rkt.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

> On Sept. 16, 2016, 12:38 a.m., Jie Yu wrote:
> > src/uri/fetchers/appc.cpp, lines 149-151
> > 
> >
> > I suggest we create a class called Rkt which abstracts the rkt tool.
> > ```
> > Rkt rkt = Rkt::create();
> > rkt->fetch(...);
> > rkt->export(...);
> > ```
> > 
> > You can do the os::which check in Rkt::create.

I did make sure that .then construct worksby moving it to a process with Fetch 
and Export methods. Apparently "export" cannot be a function name.


- Srinivas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/#review149113
---


On Sept. 19, 2016, 1:15 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50959/
> ---
> 
> (Updated Sept. 19, 2016, 1:15 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> AppcFetcherPlugin returns a '.aci' file of a container image.
> 
> Fetch supports all three modes that 'rkt fetch' supports, fetch with
> meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
> location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
> registry ex: 'docker://hello-world'.
> 
> Added new fetched plugin for Appc fetch algorithm. The new
> AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
> fetch a container image into a store specified at a directory location
> using 'rkt fetch' command and method 'rktExport' exports the image
> fetched into the directory location as a '.aci' file that is in tar
> file format, usinf 'rkt image export' command.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede 
>   src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
>   src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
>   src/uri/fetchers/rkt.hpp PRE-CREATION 
>   src/uri/fetchers/rkt.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50959/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

(Updated Sept. 19, 2016, 1:15 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location
using 'rkt fetch' command and method 'rktExport' exports the image
fetched into the directory location as a '.aci' file that is in tar
file format, usinf 'rkt image export' command.


Diffs (updated)
-

  src/Makefile.am 44fd8a216eb70d806f74b6f6acff69a2e55b7ede 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
  src/uri/fetchers/rkt.hpp PRE-CREATION 
  src/uri/fetchers/rkt.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/#review149113
---




src/Makefile.am (line 854)


I'd rename this to rkt. The fetcher plugin should be named by their 
'method', rather than 'content'. E.g., copy, curl, hadoop, etc.



src/uri/fetchers/appc.cpp (lines 99 - 103)


YOu should do this check in 'create' to fail early.



src/uri/fetchers/appc.cpp (line 108)


`.await` is a blocking call. We cannot use blocking calls as it'll block 
the worker thread. Please use .then



src/uri/fetchers/appc.cpp (line 110)


All error message should be Capitalized.



src/uri/fetchers/appc.cpp (line 116)


Ditto on await. We cannot use that because it's blocking. We only use 
'await' in tests.



src/uri/fetchers/appc.cpp (line 118)


space before and after `+`



src/uri/fetchers/appc.cpp (line 122)


Comments need to be a full sentense. Capitalize please. Please refer to the 
style guide.



src/uri/fetchers/appc.cpp (lines 149 - 151)


I suggest we create a class called Rkt which abstracts the rkt tool.
```
Rkt rkt = Rkt::create();
rkt->fetch(...);
rkt->export(...);
```

You can do the os::which check in Rkt::create.



src/uri/fetchers/appc.cpp (line 252)


Please fix all the space issue. you need space before and after `+`


- Jie Yu


On Sept. 6, 2016, 8:11 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50959/
> ---
> 
> (Updated Sept. 6, 2016, 8:11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4288
> https://issues.apache.org/jira/browse/MESOS-4288
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> AppcFetcherPlugin returns a '.aci' file of a container image.
> 
> Fetch supports all three modes that 'rkt fetch' supports, fetch with
> meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
> location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
> registry ex: 'docker://hello-world'.
> 
> Added new fetched plugin for Appc fetch algorithm. The new
> AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
> fetch a container image into a store specified at a directory location
> using 'rkt fetch' command and method 'rktExport' exports the image
> fetched into the directory location as a '.aci' file that is in tar
> file format, usinf 'rkt image export' command.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 15b9a63822eca8d0b428191940026756fba7821e 
>   src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
>   src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
>   src/uri/fetchers/appc.hpp PRE-CREATION 
>   src/uri/fetchers/appc.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50959/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

(Updated Sept. 6, 2016, 8:11 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location
using 'rkt fetch' command and method 'rktExport' exports the image
fetched into the directory location as a '.aci' file that is in tar
file format, usinf 'rkt image export' command.


Diffs (updated)
-

  src/Makefile.am 15b9a63822eca8d0b428191940026756fba7821e 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 904fce5a203c57ef1b8fdda09c81efbcf18f5d2c 
  src/uri/fetchers/appc.hpp PRE-CREATION 
  src/uri/fetchers/appc.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

(Updated Aug. 25, 2016, 3:22 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description (updated)
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location
using 'rkt fetch' command and method 'rktExport' exports the image
fetched into the directory location as a '.aci' file that is in tar
file format, usinf 'rkt image export' command.


Diffs (updated)
-

  src/Makefile.am 69e56551f0adca6d6a9811cafea9a8d3c56d1df9 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae 
  src/uri/fetchers/appc.hpp PRE-CREATION 
  src/uri/fetchers/appc.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Re: Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

(Updated Aug. 10, 2016, 7:21 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description (updated)
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with
meta discovery  ex: 'coreos.com/hello:latest', fetch from a specific 
location ex: 'https://github.com/xxx/hello.aci' or fetch from docker 
registry ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new 
AppcFetcherPlugin implements two methods. Method 'rktFetch' is used to
fetch a container image into a store specified at a directory location 
using 'rkt fetch' command and method 'rktExport' exports the image 
fetched into the directory location as a '.aci' file that is in tar 
file format, usinf 'rkt image export' command.


Diffs
-

  src/Makefile.am cf76a699c33debb129722b7cba63a4e9e09f84f7 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae 
  src/uri/fetchers/appc.hpp PRE-CREATION 
  src/uri/fetchers/appc.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu

Review Request 50959: Added appc fetcher plugin to use rkt tool.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50959/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4288
https://issues.apache.org/jira/browse/MESOS-4288


Repository: mesos


Description
---

AppcFetcherPlugin returns a '.aci' file of a container image.

Fetch supports all three modes that 'rkt fetch' supports, fetch with meta
discovery  ex: 'coreos.com/hello:latest', fetch from a specific location
ex: 'https://github.com/xxx/hello.aci' or fetch from docker registry
ex: 'docker://hello-world'.

Added new fetched plugin for Appc fetch algorithm. The new AppcFetcherPlugin
implements two methods. Method 'rktFetch' is used to fetch a container image
into a store specified at a directory location using 'rkt fetch' command and
method 'rktExport' exports the image fetched into the directory location as
a '.aci' file that is in tar file format, usinf 'rkt image export' command.


Diffs
-

  src/Makefile.am cf76a699c33debb129722b7cba63a4e9e09f84f7 
  src/uri/fetcher.hpp 949363ecdb15f5b225db7f3ed67eda52c351bfa1 
  src/uri/fetcher.cpp 198bd29993381758183edfce8faafba36da2d9ae 
  src/uri/fetchers/appc.hpp PRE-CREATION 
  src/uri/fetchers/appc.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/50959/diff/


Testing
---

make check


Thanks,

Srinivas Brahmaroutu