Re: Review Request 50964: Windows: Fix build in src/launcher/executor.*.

2016-08-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50964/
---

(Updated Aug. 10, 2016, 1:08 p.m.)


Review request for mesos, Anand Mazumdar and Artem Harutyunyan.


Changes
---

Finished debugging build on Windows.  Needed to add some more headers.


Repository: mesos


Description
---

The namespace was refactored in some other cleanup:
https://reviews.apache.org/r/50411/


Diffs (updated)
-

  src/launcher/windows/executor.hpp bae44f5188e2ca46a744a033eb3d00998b3192d6 
  src/launcher/windows/executor.cpp a7b8125e67ad6cd825fad11fd9788255c4922843 

Diff: https://reviews.apache.org/r/50964/diff/


Testing
---

Equivalent of `make` on Windows 10.


Thanks,

Joseph Wu



Re: Review Request 50964: Windows: Fix build in src/launcher/executor.*.

2016-08-10 Thread Anand Mazumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50964/#review145392
---


Ship it!




Thanks for the prompt fix!

- Anand Mazumdar


On Aug. 10, 2016, 7:29 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50964/
> ---
> 
> (Updated Aug. 10, 2016, 7:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Artem Harutyunyan.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The namespace was refactored in some other cleanup:
> https://reviews.apache.org/r/50411/
> 
> 
> Diffs
> -
> 
>   src/launcher/windows/executor.hpp bae44f5188e2ca46a744a033eb3d00998b3192d6 
>   src/launcher/windows/executor.cpp a7b8125e67ad6cd825fad11fd9788255c4922843 
> 
> Diff: https://reviews.apache.org/r/50964/diff/
> 
> 
> Testing
> ---
> 
> Equivalent of `make` on Windows 10.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 50964: Windows: Fix build in src/launcher/executor.*.

2016-08-10 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50964/
---

Review request for mesos, Anand Mazumdar and Artem Harutyunyan.


Repository: mesos


Description
---

The namespace was refactored in some other cleanup:
https://reviews.apache.org/r/50411/


Diffs
-

  src/launcher/windows/executor.hpp bae44f5188e2ca46a744a033eb3d00998b3192d6 
  src/launcher/windows/executor.cpp a7b8125e67ad6cd825fad11fd9788255c4922843 

Diff: https://reviews.apache.org/r/50964/diff/


Testing
---

Equivalent of `make` on Windows 10.


Thanks,

Joseph Wu