Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

2016-08-26 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51407/
---

(Updated Aug. 26, 2016, 9:59 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Updated based on Jie's comments.


Bugs: MESOS-6088
https://issues.apache.org/jira/browse/MESOS-6088


Repository: mesos


Description
---

This includes an updated to tests to account for new 'init' process
semantics in a container. That is, the init process of the new
container is now "mesos-containerizer" not "sh".


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
8a8985a6627859365c4f87ea0cbb5f89190cd4b3 
  src/tests/containerizer/isolator_tests.cpp 
2725eb0f76f4e2668381c0d6686a99649f4f9f25 

Diff: https://reviews.apache.org/r/51407/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

2016-08-26 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51407/#review147023
---


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.cpp (line 1221)


Add some TODO about that this feature is only used by LinuxLauncher for 
now. We'll support Posix launcher later.



src/slave/containerizer/mesos/containerizer.cpp (lines 1222 - 1225)


Fix indentation here please.


- Jie Yu


On Aug. 26, 2016, 8:39 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51407/
> ---
> 
> (Updated Aug. 26, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6088
> https://issues.apache.org/jira/browse/MESOS-6088
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This includes an updated to tests to account for new 'init' process
> semantics in a container. That is, the init process of the new
> container is now "mesos-containerizer" not "sh".
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 8a8985a6627859365c4f87ea0cbb5f89190cd4b3 
>   src/tests/containerizer/isolator_tests.cpp 
> 2725eb0f76f4e2668381c0d6686a99649f4f9f25 
> 
> Diff: https://reviews.apache.org/r/51407/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

2016-08-25 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51407/
---

(Updated Aug. 25, 2016, 11:34 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Merged test changes into this patch to make the commit *atomic*


Bugs: MESOS-6088
https://issues.apache.org/jira/browse/MESOS-6088


Repository: mesos


Description (updated)
---

This includes an updated to tests to account for new 'init' process
semantics in a container. That is, the init process of the new
container is now "mesos-containerizer" not "sh".


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
8a8985a6627859365c4f87ea0cbb5f89190cd4b3 
  src/tests/containerizer/isolator_tests.cpp 
2725eb0f76f4e2668381c0d6686a99649f4f9f25 

Diff: https://reviews.apache.org/r/51407/diff/


Testing
---


Thanks,

Kevin Klues

Review Request 51407: Updated mesos containerizer to checkpoint the container exit status.

2016-08-24 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51407/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-6088
https://issues.apache.org/jira/browse/MESOS-6088


Repository: mesos


Description
---

Updated mesos containerizer to checkpoint the container exit status.


Diffs
-

  src/slave/containerizer/mesos/containerizer.cpp 
8a8985a6627859365c4f87ea0cbb5f89190cd4b3 

Diff: https://reviews.apache.org/r/51407/diff/


Testing
---


Thanks,

Kevin Klues