Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-30 Thread Anindya Sinha 


> On Aug. 29, 2016, 7:26 a.m., Anindya Sinha wrote:
> > I think we should also bring back this function:
> > `const hashmap& total()`.
> 
> Jiang Yan Xu wrote:
> Why? The total is now fully hidden and we only need to reply on it within 
> DRFSorter for shared resources.
> 
> Jiang Yan Xu wrote:
> *rely

Ok. Makes sense.


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/#review147118
---


On Aug. 26, 2016, 10:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51470/
> ---
> 
> (Updated Aug. 26, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, 
> and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
> We used to have this field but it turned out to be unnecessary for the
> current use cases so it was removed. We however will need it for the
> ongoing work to support tasks using shared resources.
> 
> The details can be found in https://reviews.apache.org/r/45961 but in
> essence, we now know of a case where the removal of resource quantities
> from the sorter depends on the identity. e.g., To determine if the
> quantity of a shared resource can be removed from the sorter we need to
> know if there are no longer instances of **the same** (hence identity)
> shared resource in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
>   src/master/allocator/sorter/drf/sorter.cpp 
> ac85b327fc33d34246788e6a8c8bf5a486c61434 
> 
> Diff: https://reviews.apache.org/r/51470/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-29 Thread Jiang Yan Xu 


> On Aug. 29, 2016, 12:26 a.m., Anindya Sinha wrote:
> > I think we should also bring back this function:
> > `const hashmap& total()`.
> 
> Jiang Yan Xu wrote:
> Why? The total is now fully hidden and we only need to reply on it within 
> DRFSorter for shared resources.

*rely


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/#review147118
---


On Aug. 26, 2016, 3:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51470/
> ---
> 
> (Updated Aug. 26, 2016, 3:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, 
> and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
> We used to have this field but it turned out to be unnecessary for the
> current use cases so it was removed. We however will need it for the
> ongoing work to support tasks using shared resources.
> 
> The details can be found in https://reviews.apache.org/r/45961 but in
> essence, we now know of a case where the removal of resource quantities
> from the sorter depends on the identity. e.g., To determine if the
> quantity of a shared resource can be removed from the sorter we need to
> know if there are no longer instances of **the same** (hence identity)
> shared resource in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
>   src/master/allocator/sorter/drf/sorter.cpp 
> ac85b327fc33d34246788e6a8c8bf5a486c61434 
> 
> Diff: https://reviews.apache.org/r/51470/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-29 Thread Jiang Yan Xu 


> On Aug. 29, 2016, 12:26 a.m., Anindya Sinha wrote:
> > I think we should also bring back this function:
> > `const hashmap& total()`.

Why? The total is now fully hidden and we only need to reply on it within 
DRFSorter for shared resources.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/#review147118
---


On Aug. 26, 2016, 3:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51470/
> ---
> 
> (Updated Aug. 26, 2016, 3:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, 
> and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
> We used to have this field but it turned out to be unnecessary for the
> current use cases so it was removed. We however will need it for the
> ongoing work to support tasks using shared resources.
> 
> The details can be found in https://reviews.apache.org/r/45961 but in
> essence, we now know of a case where the removal of resource quantities
> from the sorter depends on the identity. e.g., To determine if the
> quantity of a shared resource can be removed from the sorter we need to
> know if there are no longer instances of **the same** (hence identity)
> shared resource in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
>   src/master/allocator/sorter/drf/sorter.cpp 
> ac85b327fc33d34246788e6a8c8bf5a486c61434 
> 
> Diff: https://reviews.apache.org/r/51470/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-29 Thread Anindya Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/#review147118
---



I think we should also bring back this function:
`const hashmap& total()`.

- Anindya Sinha


On Aug. 26, 2016, 10:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51470/
> ---
> 
> (Updated Aug. 26, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, 
> and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
> We used to have this field but it turned out to be unnecessary for the
> current use cases so it was removed. We however will need it for the
> ongoing work to support tasks using shared resources.
> 
> The details can be found in https://reviews.apache.org/r/45961 but in
> essence, we now know of a case where the removal of resource quantities
> from the sorter depends on the identity. e.g., To determine if the
> quantity of a shared resource can be removed from the sorter we need to
> know if there are no longer instances of **the same** (hence identity)
> shared resource in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
>   src/master/allocator/sorter/drf/sorter.cpp 
> ac85b327fc33d34246788e6a8c8bf5a486c61434 
> 
> Diff: https://reviews.apache.org/r/51470/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-26 Thread Anindya Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/#review147062
---


Ship it!




Ship It!

- Anindya Sinha


On Aug. 26, 2016, 10:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51470/
> ---
> 
> (Updated Aug. 26, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, 
> and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
> We used to have this field but it turned out to be unnecessary for the
> current use cases so it was removed. We however will need it for the
> ongoing work to support tasks using shared resources.
> 
> The details can be found in https://reviews.apache.org/r/45961 but in
> essence, we now know of a case where the removal of resource quantities
> from the sorter depends on the identity. e.g., To determine if the
> quantity of a shared resource can be removed from the sorter we need to
> know if there are no longer instances of **the same** (hence identity)
> shared resource in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
>   src/master/allocator/sorter/drf/sorter.cpp 
> ac85b327fc33d34246788e6a8c8bf5a486c61434 
> 
> Diff: https://reviews.apache.org/r/51470/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/#review147058
---



Patch looks great!

Reviews applied: [51470]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 26, 2016, 10:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51470/
> ---
> 
> (Updated Aug. 26, 2016, 10:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, 
> and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
> We used to have this field but it turned out to be unnecessary for the
> current use cases so it was removed. We however will need it for the
> ongoing work to support tasks using shared resources.
> 
> The details can be found in https://reviews.apache.org/r/45961 but in
> essence, we now know of a case where the removal of resource quantities
> from the sorter depends on the identity. e.g., To determine if the
> quantity of a shared resource can be removed from the sorter we need to
> know if there are no longer instances of **the same** (hence identity)
> shared resource in the sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/sorter/drf/sorter.hpp 
> bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
>   src/master/allocator/sorter/drf/sorter.cpp 
> ac85b327fc33d34246788e6a8c8bf5a486c61434 
> 
> Diff: https://reviews.apache.org/r/51470/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

2016-08-26 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51470/
---

Review request for mesos, Alexander Rukletsov, Anindya Sinha, Michael Park, and 
Neil Conway.


Repository: mesos


Description
---

This is a partial reversal of 5a63f2a5d2a5fe0e5315a5b8f79b75b99a6a5893.
We used to have this field but it turned out to be unnecessary for the
current use cases so it was removed. We however will need it for the
ongoing work to support tasks using shared resources.

The details can be found in https://reviews.apache.org/r/45961 but in
essence, we now know of a case where the removal of resource quantities
from the sorter depends on the identity. e.g., To determine if the
quantity of a shared resource can be removed from the sorter we need to
know if there are no longer instances of **the same** (hence identity)
shared resource in the sorter.


Diffs
-

  src/master/allocator/sorter/drf/sorter.hpp 
bc6bfb2d5d3b32d55be055a0514861b4e7d889bb 
  src/master/allocator/sorter/drf/sorter.cpp 
ac85b327fc33d34246788e6a8c8bf5a486c61434 

Diff: https://reviews.apache.org/r/51470/diff/


Testing
---

make check


Thanks,

Jiang Yan Xu