Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-21 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52096/#review149886
---




src/slave/container_loggers/lib_logrotate.cpp (lines 142 - 145)


Based on the comment I left in the previous review, you will end up 
changing how change the user is saved.

```
Option user = None();
if (executorInfo.has_command() &&
executorInfo.command().has_user()) {
  user = executorInfo.command().user();
}
```
(Note the differences in this example's spacing and your spacing.)



src/slave/container_loggers/lib_logrotate.cpp (line 178)


Similarly, this will change to 
```
outFlags.user = user;
```

Ditto with `errFlags`.


- Joseph Wu


On Sept. 20, 2016, 8:54 p.m., Sivaram Kannan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52096/
> ---
> 
> (Updated Sept. 20, 2016, 8:54 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-5856
> https://issues.apache.org/jira/browse/MESOS-5856
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Read  user details passed in executorInfo and assign it to user flag.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1c170e5d11ef31d468b200c2c4cbd27abeeb418a 
> 
> Diff: https://reviews.apache.org/r/52096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sivaram Kannan
> 
>

Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-20 Thread Sivaram Kannan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52096/
---

(Updated Sept. 21, 2016, 3:54 a.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Read  user details passed in executorInfo and assign it to user flag.


Diffs (updated)
-

  src/slave/container_loggers/lib_logrotate.cpp 
1c170e5d11ef31d468b200c2c4cbd27abeeb418a 

Diff: https://reviews.apache.org/r/52096/diff/


Testing
---


Thanks,

Sivaram Kannan

Re: Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-20 Thread Sivaram Kannan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52096/
---

(Updated Sept. 21, 2016, 1:02 a.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-5856
https://issues.apache.org/jira/browse/MESOS-5856


Repository: mesos


Description
---

Read  user details passed in executorInfo and assign it to user flag.


Diffs
-

  src/slave/container_loggers/lib_logrotate.cpp 
1c170e5d11ef31d468b200c2c4cbd27abeeb418a 

Diff: https://reviews.apache.org/r/52096/diff/


Testing
---


Thanks,

Sivaram Kannan

Review Request 52096: Read user details passed in executorInfo and assign it to user flag.

2016-09-20 Thread Sivaram Kannan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52096/
---

Review request for mesos and Joseph Wu.


Repository: mesos


Description
---

Read  user details passed in executorInfo and assign it to user flag.


Diffs
-

  src/slave/container_loggers/lib_logrotate.cpp 
1c170e5d11ef31d468b200c2c4cbd27abeeb418a 

Diff: https://reviews.apache.org/r/52096/diff/


Testing
---


Thanks,

Sivaram Kannan