Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 3:29 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:49 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:38 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 30, 2016, 2:17 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review150988 --- Bad patch! Reviews applied: [52310, 52309, 52308] Failed command: ./support/apply-review.sh -n -r 52309 Error: 2016-09-30 05:52:04 URL:https://reviews.apache.org/r/52309/diff/raw/ [1106/1106] -> "52309.patch" [1] error: patch failed: src/slave/container_loggers/lib_logrotate.cpp:173 error: src/slave/container_loggers/lib_logrotate.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15458/console - Mesos ReviewBot On Sept. 29, 2016, 6:47 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52310/ > --- > > (Updated Sept. 29, 2016, 6:47 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Switch the uid to passed user before spawning the process. > > > Diffs > - > > src/slave/container_loggers/logrotate.cpp > 431bc3cbb54e94359078e4dae0b32ad301393640 > > Diff: https://reviews.apache.org/r/52310/diff/ > > > Testing > --- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 29, 2016, 6:47 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 29, 2016, 6:37 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Switch the uid to passed user before spawning the process. Diffs - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
Re: Review Request 52310: Switch the uid to passed user before spawning the process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 29, 2016, 3:55 p.m.) Review request for mesos and Joseph Wu. Summary (updated) - Switch the uid to passed user before spawning the process. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Switch the uid to passed user before spawning the process. Diffs (updated) - src/slave/container_loggers/logrotate.cpp 431bc3cbb54e94359078e4dae0b32ad301393640 Diff: https://reviews.apache.org/r/52310/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. Thanks, Sivaram Kannan
