Re: Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52387/#review152754 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52387/ > --- > > (Updated Oct. 6, 2016, 2:58 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3335 > https://issues.apache.org/jira/browse/MESOS-3335 > > > Repository: mesos > > > Description > --- > > In order for different `Flags` classes to be composable classes should > always use virtual inheritance. > > > Diffs > - > > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > c8350cf8e512dca23933725e6edb3e3d94380211 > > Diff: https://reviews.apache.org/r/52387/diff/ > > > Testing > --- > > Tested as part of the review chain ending in > https://reviews.apache.org/r/52388/ on various Linux configurations in > internal CI. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52387/ --- (Updated Oct. 6, 2016, 4:58 p.m.) Review request for mesos and Michael Park. Changes --- Rebased. Bugs: MESOS-3335 https://issues.apache.org/jira/browse/MESOS-3335 Repository: mesos Description (updated) --- In order for different `Flags` classes to be composable classes should always use virtual inheritance. Diffs (updated) - 3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf8e512dca23933725e6edb3e3d94380211 Diff: https://reviews.apache.org/r/52387/diff/ Testing --- Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various Linux configurations in internal CI. Thanks, Benjamin Bannier
Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52387/ --- Review request for mesos and Michael Park. Bugs: MESOS-3335 https://issues.apache.org/jira/browse/MESOS-3335 Repository: mesos Description --- Consistently used virtual inheritance for Flags classes in libprocess. Diffs - 3rdparty/libprocess/include/process/ssl/flags.hpp 13fa7a0cc9d6d6d6849976a3ce383263c51504d7 3rdparty/libprocess/src/tests/ssl_client.cpp 8d62fc2975b585013a8d9a6efc967314d6d8ec47 3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf8e512dca23933725e6edb3e3d94380211 Diff: https://reviews.apache.org/r/52387/diff/ Testing --- Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various Linux configurations in internal CI. Thanks, Benjamin Bannier
