Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Anindya Sinha]

> On Nov. 2, 2016, 10:36 p.m., Joseph Wu wrote:
> > src/slave/containerizer/fetcher.cpp, lines 788-790
> > 
> >
> > This short-circuit leaks the two FDs opened above.

RR for this fix: https://reviews.apache.org/r/53413


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/#review154647
---


On Oct. 14, 2016, 6:14 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52828/
> ---
> 
> (Updated Oct. 14, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: mesos-5218
> https://issues.apache.org/jira/browse/mesos-5218
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the uri.size() check in fetcher so that the chown to
> task user of stdout/stderr in sandbox directory happens even
> when there is no uri to be fetched.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.cpp 
> 11104d66e6dd05d8eb1d37a2e3250aca19278110 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52828/diff/
> 
> 
> Testing
> ---
> 
> make check on macOs and linux
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/#review154647
---




src/slave/containerizer/fetcher.cpp (lines 784 - 786)


This short-circuit leaks the two FDs opened above.


- Joseph Wu


On Oct. 14, 2016, 11:14 a.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52828/
> ---
> 
> (Updated Oct. 14, 2016, 11:14 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: mesos-5218
> https://issues.apache.org/jira/browse/mesos-5218
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the uri.size() check in fetcher so that the chown to
> task user of stdout/stderr in sandbox directory happens even
> when there is no uri to be fetched.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.cpp 
> 11104d66e6dd05d8eb1d37a2e3250aca19278110 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52828/diff/
> 
> 
> Testing
> ---
> 
> make check on macOs and linux
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Megha Sharma]

> On Oct. 13, 2016, 11:47 p.m., Jiang Yan Xu wrote:
> > src/tests/slave_tests.cpp, line 932
> > 
> >
> > "test" worked? Could you verify?

"test" didn't work since we are chowning so needs a real user. Replaced it with 
"nobody".


- Megha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/#review152606
---


On Oct. 14, 2016, 6:14 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52828/
> ---
> 
> (Updated Oct. 14, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: mesos-5218
> https://issues.apache.org/jira/browse/mesos-5218
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the uri.size() check in fetcher so that the chown to
> task user of stdout/stderr in sandbox directory happens even
> when there is no uri to be fetched.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.cpp 
> 11104d66e6dd05d8eb1d37a2e3250aca19278110 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52828/diff/
> 
> 
> Testing
> ---
> 
> make check on macOs and linux
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/
---

(Updated Oct. 14, 2016, 6:14 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: mesos-5218
https://issues.apache.org/jira/browse/mesos-5218


Repository: mesos


Description
---

Moved the uri.size() check in fetcher so that the chown to
task user of stdout/stderr in sandbox directory happens even
when there is no uri to be fetched.


Diffs (updated)
-

  src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 
  src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 

Diff: https://reviews.apache.org/r/52828/diff/


Testing
---

make check on macOs and linux


Thanks,

Megha Sharma

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/#review152606
---


Fix it, then Ship it!





src/tests/slave_tests.cpp (line 932)


"test" worked? Could you verify?


- Jiang Yan Xu


On Oct. 13, 2016, 2:36 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52828/
> ---
> 
> (Updated Oct. 13, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: mesos-5218
> https://issues.apache.org/jira/browse/mesos-5218
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the uri.size() check in fetcher so that the chown to
> task user of stdout/stderr in sandbox directory happens even
> when there is no uri to be fetched.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/fetcher.cpp 
> 11104d66e6dd05d8eb1d37a2e3250aca19278110 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52828/diff/
> 
> 
> Testing
> ---
> 
> make check on macOs and linux
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/
---

(Updated Oct. 13, 2016, 9:36 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: mesos-5218
https://issues.apache.org/jira/browse/mesos-5218


Repository: mesos


Description
---

Moved the uri.size() check in fetcher so that the chown to
task user of stdout/stderr in sandbox directory happens even
when there is no uri to be fetched.


Diffs
-

  src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 
  src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 

Diff: https://reviews.apache.org/r/52828/diff/


Testing (updated)
---

make check on macOs and linux


Thanks,

Megha Sharma

Re: Review Request 52828: Allow the chown code in fetcher to be executed.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52828/
---

(Updated Oct. 13, 2016, 2:33 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: mesos-5218
https://issues.apache.org/jira/browse/mesos-5218


Repository: mesos


Description
---

Moved the uri.size() check in fetcher so that the chown to
task user of stdout/stderr in sandbox directory happens even
when there is no uri to be fetched.


Diffs (updated)
-

  src/slave/containerizer/fetcher.cpp 11104d66e6dd05d8eb1d37a2e3250aca19278110 
  src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 

Diff: https://reviews.apache.org/r/52828/diff/


Testing
---


Thanks,

Megha Sharma