Re: Review Request 52855: Re-enabled the change user test in slave tests.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52855/#review167395
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 14, 2016, 3:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52855/
> ---
> 
> (Updated Oct. 14, 2016, 3:36 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6391
> https://issues.apache.org/jira/browse/MESOS-6391
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that the sandbox of the command task is writable if
> the task specifies a non privileged user.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> 
> Diff: https://reviews.apache.org/r/52855/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 52855: Re-enabled the change user test in slave tests.

2016-10-14 Thread Gilbert Song 


> On Oct. 14, 2016, 11:56 a.m., Gilbert Song wrote:
> > src/tests/slave_tests.cpp, lines 1163-1165
> > 
> >
> > Use `createDockerImage()`.

Please discard this comment.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52855/#review152709
---


On Oct. 13, 2016, 8:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52855/
> ---
> 
> (Updated Oct. 13, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6391
> https://issues.apache.org/jira/browse/MESOS-6391
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that the sandbox of the command task is writable if
> the task specifies a non privileged user.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52855/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 52855: Re-enabled the change user test in slave tests.

2016-10-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52855/#review152709
---


Fix it, then Ship it!





src/tests/slave_tests.cpp (line 1045)


s/ROOT_RunTaskWithCommandInfoWithUser/ROOT_RunTaskWithCommandInfoUser



src/tests/slave_tests.cpp (lines 1106 - 1108)


Use `createDockerImage()`.



src/tests/slave_tests.cpp (lines 1106 - 1112)


Use `createContainerInfo()`.


- Gilbert Song


On Oct. 13, 2016, 8:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52855/
> ---
> 
> (Updated Oct. 13, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6391
> https://issues.apache.org/jira/browse/MESOS-6391
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that the sandbox of the command task is writable if
> the task specifies a non privileged user.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52855/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 52855: Re-enabled the change user test in slave tests.

2016-10-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52855/#review152661
---



Patch looks great!

Reviews applied: [52854, 52855]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 14, 2016, 3:36 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52855/
> ---
> 
> (Updated Oct. 14, 2016, 3:36 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-6391
> https://issues.apache.org/jira/browse/MESOS-6391
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that the sandbox of the command task is writable if
> the task specifies a non privileged user.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
>   src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 
> 
> Diff: https://reviews.apache.org/r/52855/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 52855: Re-enabled the change user test in slave tests.

2016-10-13 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52855/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-6391
https://issues.apache.org/jira/browse/MESOS-6391


Repository: mesos


Description
---

This test verifies that the sandbox of the command task is writable if
the task specifies a non privileged user.


Diffs
-

  src/tests/containerizer/rootfs.hpp 6bc3835cbb62536ec933ef38c9e15138b8611e5f 
  src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc 

Diff: https://reviews.apache.org/r/52855/diff/


Testing
---

sudo make check


Thanks,

Jie Yu