Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

2016-11-14 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/
---

(Updated Nov. 14, 2016, 10:30 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

After the task has been terminated, its health updates
become irrelevant and should be ignored.


Diffs (updated)
-

  src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 

Diff: https://reviews.apache.org/r/52869/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov



Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

2016-11-11 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/
---

(Updated Nov. 11, 2016, 3:22 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

After the task has been terminated, its health updates
become irrelevant and should be ignored.


Diffs
-

  src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 

Diff: https://reviews.apache.org/r/52869/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov



Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

2016-10-17 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/#review152907
---


Ship it!




Ship It!

- haosdent huang


On Oct. 14, 2016, 12:41 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52869/
> ---
> 
> (Updated Oct. 14, 2016, 12:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.
> 
> 
> Bugs: MESOS-5963
> https://issues.apache.org/jira/browse/MESOS-5963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After the task has been terminated, its health updates
> become irrelevant and should be ignored.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 
> 
> Diff: https://reviews.apache.org/r/52869/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

2016-10-14 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/#review152685
---


Ship it!




Ship It!

- Gastón Kleiman


On Oct. 14, 2016, 12:41 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52869/
> ---
> 
> (Updated Oct. 14, 2016, 12:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.
> 
> 
> Bugs: MESOS-5963
> https://issues.apache.org/jira/browse/MESOS-5963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After the task has been terminated, its health updates
> become irrelevant and should be ignored.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 
> 
> Diff: https://reviews.apache.org/r/52869/diff/
> 
> 
> Testing
> ---
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

2016-10-14 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52869/
---

Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang.


Bugs: MESOS-5963
https://issues.apache.org/jira/browse/MESOS-5963


Repository: mesos


Description
---

After the task has been terminated, its health updates
become irrelevant and should be ignored.


Diffs
-

  src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 

Diff: https://reviews.apache.org/r/52869/diff/


Testing
---

See https://reviews.apache.org/r/52873/.


Thanks,

Alexander Rukletsov