Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 14, 2016, 10:30 a.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. Bugs: MESOS-5963 https://issues.apache.org/jira/browse/MESOS-5963 Repository: mesos Description --- After the task has been terminated, its health updates become irrelevant and should be ignored. Now it is safe to start health checks even if the task has been asked to terminate. Diffs (updated) - src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 Diff: https://reviews.apache.org/r/52870/diff/ Testing --- See https://reviews.apache.org/r/52873/. Thanks, Alexander Rukletsov
Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 11, 2016, 3:22 p.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. Bugs: MESOS-5963 https://issues.apache.org/jira/browse/MESOS-5963 Repository: mesos Description --- After the task has been terminated, its health updates become irrelevant and should be ignored. Now it is safe to start health checks even if the task has been asked to terminate. Diffs - src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 Diff: https://reviews.apache.org/r/52870/diff/ Testing --- See https://reviews.apache.org/r/52873/. Thanks, Alexander Rukletsov
Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 11, 2016, 3:20 p.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. Bugs: MESOS-5963 https://issues.apache.org/jira/browse/MESOS-5963 Repository: mesos Description --- After the task has been terminated, its health updates become irrelevant and should be ignored. Now it is safe to start health checks even if the task has been asked to terminate. Diffs - src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 Diff: https://reviews.apache.org/r/52870/diff/ Testing --- See https://reviews.apache.org/r/52873/. Thanks, Alexander Rukletsov
Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/#review152906 --- Ship it! Ship It! - haosdent huang On Oct. 14, 2016, 12:42 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52870/ > --- > > (Updated Oct. 14, 2016, 12:42 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > --- > > After the task has been terminated, its health updates become > irrelevant and should be ignored. Now it is safe to start health > checks even if the task has been asked to terminate. > > > Diffs > - > > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > > Diff: https://reviews.apache.org/r/52870/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/#review152699 --- Ship it! Ship It! - Gastón Kleiman On Oct. 14, 2016, 12:42 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52870/ > --- > > (Updated Oct. 14, 2016, 12:42 p.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. > > > Bugs: MESOS-5963 > https://issues.apache.org/jira/browse/MESOS-5963 > > > Repository: mesos > > > Description > --- > > After the task has been terminated, its health updates become > irrelevant and should be ignored. Now it is safe to start health > checks even if the task has been asked to terminate. > > > Diffs > - > > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > > Diff: https://reviews.apache.org/r/52870/diff/ > > > Testing > --- > > See https://reviews.apache.org/r/52873/. > > > Thanks, > > Alexander Rukletsov > >
Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and haosdent huang. Bugs: MESOS-5963 https://issues.apache.org/jira/browse/MESOS-5963 Repository: mesos Description --- After the task has been terminated, its health updates become irrelevant and should be ignored. Now it is safe to start health checks even if the task has been asked to terminate. Diffs - src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 Diff: https://reviews.apache.org/r/52870/diff/ Testing --- See https://reviews.apache.org/r/52873/. Thanks, Alexander Rukletsov
