Re: Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52901/
---

(Updated Oct. 15, 2016, 12:03 a.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
---

benm's. NNFR.


Repository: mesos


Description
---

This is very minimal documentation mainly around the new framework
APIs and the default executor.


Diffs (updated)
-

  CHANGELOG 1b8fa346d916f941841bd34b264c8803e4286dc4 
  docs/app-framework-development-guide.md 
84521cdf32e75599988e55f5f50e94b032eed62f 
  docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 
  docs/scheduler-http-api.md a27965abac1263542f0711d997804c0bcec5a716 

Diff: https://reviews.apache.org/r/52901/diff/


Testing
---


Thanks,

Vinod Kone

Re: Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

[Vinod Kone]

> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > CHANGELOG, lines 5-10
> > 
> >
> > It would be nice to distinguish the nested container support and the 
> > task group support in the changelog, i.e. we include nested container 
> > support for executors / operators to launch nested containers within an 
> > executor's container, and if you launch a task group using the default 
> > executor it will use a nested container for each task (using the new 
> > support for it).

Good idea. Done.


> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > CHANGELOG, line 7
> > 
> >
> > "all or none of the tasks in the group" ?

done


> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > docs/app-framework-development-guide.md, lines 18-24
> > 
> >
> > Is this related or did you want to pull this out into a separate commit?

i'll pull this and executor related change into a separate commit.


> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > docs/app-framework-development-guide.md, line 329
> > 
> >
> > Not the freezer though.. right? Should we tell them about the cgroup 
> > level detail here or do they just need to know about the visible isolation 
> > semantics and namespaces?

I'll remove cgroups and talk about isolation semantics here. Thanks.


> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > docs/app-framework-development-guide.md, line 335
> > 
> >
> > Do we want to call out that the other namespaces are not shared?

made it more generic.


> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > docs/scheduler-http-api.md, line 275
> > 
> >
> > A little muddled?

rephrased.


> On Oct. 14, 2016, 11:23 p.m., Benjamin Mahler wrote:
> > docs/app-framework-development-guide.md, lines 364-370
> > 
> >
> > Related?

moved to a separate commit.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52901/#review152759
---


On Oct. 14, 2016, 10:15 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52901/
> ---
> 
> (Updated Oct. 14, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is very minimal documentation mainly around the new framework
> APIs and the default executor.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1b8fa346d916f941841bd34b264c8803e4286dc4 
>   docs/app-framework-development-guide.md 
> 84521cdf32e75599988e55f5f50e94b032eed62f 
>   docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 
>   docs/scheduler-http-api.md a27965abac1263542f0711d997804c0bcec5a716 
> 
> Diff: https://reviews.apache.org/r/52901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52901/#review152759
---


Fix it, then Ship it!





CHANGELOG (lines 5 - 10)


It would be nice to distinguish the nested container support and the task 
group support in the changelog, i.e. we include nested container support for 
executors / operators to launch nested containers within an executor's 
container, and if you launch a task group using the default executor it will 
use a nested container for each task (using the new support for it).



CHANGELOG (line 7)


"all or none of the tasks in the group" ?



docs/app-framework-development-guide.md (lines 18 - 24)


Is this related or did you want to pull this out into a separate commit?



docs/app-framework-development-guide.md (line 329)


Not the freezer though.. right? Should we tell them about the cgroup level 
detail here or do they just need to know about the visible isolation semantics 
and namespaces?



docs/app-framework-development-guide.md (line 335)


Do we want to call out that the other namespaces are not shared?



docs/app-framework-development-guide.md (lines 364 - 370)


Related?



docs/scheduler-http-api.md (line 275)


A little muddled?


- Benjamin Mahler


On Oct. 14, 2016, 10:15 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52901/
> ---
> 
> (Updated Oct. 14, 2016, 10:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is very minimal documentation mainly around the new framework
> APIs and the default executor.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1b8fa346d916f941841bd34b264c8803e4286dc4 
>   docs/app-framework-development-guide.md 
> 84521cdf32e75599988e55f5f50e94b032eed62f 
>   docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 
>   docs/scheduler-http-api.md a27965abac1263542f0711d997804c0bcec5a716 
> 
> Diff: https://reviews.apache.org/r/52901/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 52901: Added documentation for default executor and LAUNCH_GROUP event.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52901/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Repository: mesos


Description
---

This is very minimal documentation mainly around the new framework
APIs and the default executor.


Diffs
-

  CHANGELOG 1b8fa346d916f941841bd34b264c8803e4286dc4 
  docs/app-framework-development-guide.md 
84521cdf32e75599988e55f5f50e94b032eed62f 
  docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 
  docs/scheduler-http-api.md a27965abac1263542f0711d997804c0bcec5a716 

Diff: https://reviews.apache.org/r/52901/diff/


Testing
---


Thanks,

Vinod Kone