Re: Review Request 52902: Updated default value of the '--runtime_dir' agent flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52902/#review152765 --- Ship it! Ship It! - Vinod Kone On Oct. 15, 2016, 12:05 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52902/ > --- > > (Updated Oct. 15, 2016, 12:05 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-6050 > https://issues.apache.org/jira/browse/MESOS-6050 > > > Repository: mesos > > > Description > --- > > Previously, the default value of '--runtime_dir' was hard coded to > '/var/run/mesos'. However, this directory is typically only accessable > to the 'root' user. This caused problems when launching an agent as a > non-root user. We now check to see if the agent is launched as root or > not, and change this default accordingly. > > > Diffs > - > > src/slave/constants.hpp 064072197c4f8ea15b52b5e257cdb44879b34237 > src/slave/flags.cpp 7f79cfcc7939680c38a3d0cd57471cc9976aff7c > > Diff: https://reviews.apache.org/r/52902/diff/ > > > Testing > --- > > $ GTEST_FILTER="" make -j check > $ src/mesos-tests > > $ bin/mesos-local.sh > ``` > Flags at startup: ... --runtime_dir="/tmp/mesos/runtime" > ``` > > > Thanks, > > Kevin Klues > >
Re: Review Request 52902: Updated default value of the '--runtime_dir' agent flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52902/ --- (Updated Oct. 15, 2016, 12:05 a.m.) Review request for mesos. Bugs: MESOS-6050 https://issues.apache.org/jira/browse/MESOS-6050 Repository: mesos Description --- Previously, the default value of '--runtime_dir' was hard coded to '/var/run/mesos'. However, this directory is typically only accessable to the 'root' user. This caused problems when launching an agent as a non-root user. We now check to see if the agent is launched as root or not, and change this default accordingly. Diffs - src/slave/constants.hpp 064072197c4f8ea15b52b5e257cdb44879b34237 src/slave/flags.cpp 7f79cfcc7939680c38a3d0cd57471cc9976aff7c Diff: https://reviews.apache.org/r/52902/diff/ Testing --- $ GTEST_FILTER="" make -j check $ src/mesos-tests $ bin/mesos-local.sh ``` Flags at startup: ... --runtime_dir="/tmp/mesos/runtime" ``` Thanks, Kevin Klues
Review Request 52902: Updated default value of the '--runtime_dir' agent flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52902/ --- Review request for mesos. Repository: mesos Description --- Previously, the default value of '--runtime_dir' was hard coded to '/var/run/mesos'. However, this directory is typically only accessable to the 'root' user. This caused problems when launching an agent as a non-root user. We now check to see if the agent is launched as root or not, and change this default accordingly. Diffs - src/slave/constants.hpp 064072197c4f8ea15b52b5e257cdb44879b34237 src/slave/flags.cpp 7f79cfcc7939680c38a3d0cd57471cc9976aff7c Diff: https://reviews.apache.org/r/52902/diff/ Testing --- $ GTEST_FILTER="" make -j check $ src/mesos-tests $ bin/mesos-local.sh ``` Flags at startup: ... --runtime_dir="/tmp/mesos/runtime" ``` Thanks, Kevin Klues
