Re: Review Request 53267: Added a gauge to track active subscribers.

2018-04-30 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
---

(Updated April 30, 2018, 1:53 p.m.)


Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.


Changes
---

Rebase and move.


Bugs: MESOS-6499
https://issues.apache.org/jira/browse/MESOS-6499


Repository: mesos


Description
---

Added a gauge to track active subscribers.


Diffs (updated)
-

  src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
  src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 


Diff: https://reviews.apache.org/r/53267/diff/3/

Changes: https://reviews.apache.org/r/53267/diff/2-3/


Testing
---

Ran this on master with a client keeps subscribing and disconnecting. Observes 
that gauge gets updated and new log line is printed.


Thanks,

Zhitao Li

Re: Review Request 53267: Added a gauge to track active subscribers.

2018-04-16 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/#review201256
---



Please document the new metric in `monitoring.md`.


src/master/master.hpp
Lines 2144 (patched)


Nit. This should be in `master.cpp` for consistency with the other gauges.


- James Peach


On April 12, 2018, 9:33 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53267/
> ---
> 
> (Updated April 12, 2018, 9:33 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-6499
> https://issues.apache.org/jira/browse/MESOS-6499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a gauge to track active subscribers.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
>   src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 
> 
> 
> Diff: https://reviews.apache.org/r/53267/diff/2/
> 
> 
> Testing
> ---
> 
> Ran this on master with a client keeps subscribing and disconnecting. 
> Observes that gauge gets updated and new log line is printed.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 53267: Added a gauge to track active subscribers.

2018-04-12 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/#review201073
---



Patch looks great!

Reviews applied: [53267]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 12, 2018, 9:33 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53267/
> ---
> 
> (Updated April 12, 2018, 9:33 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-6499
> https://issues.apache.org/jira/browse/MESOS-6499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a gauge to track active subscribers.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
>   src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 
> 
> 
> Diff: https://reviews.apache.org/r/53267/diff/2/
> 
> 
> Testing
> ---
> 
> Ran this on master with a client keeps subscribing and disconnecting. 
> Observes that gauge gets updated and new log line is printed.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 53267: Added a gauge to track active subscribers.

2018-04-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/#review201060
---



PASS: Mesos patch 53267 was successfully built and tested.

Reviews applied: `['53267']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/53267

- Mesos Reviewbot Windows


On April 12, 2018, 9:33 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53267/
> ---
> 
> (Updated April 12, 2018, 9:33 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jason Lai, and James Peach.
> 
> 
> Bugs: MESOS-6499
> https://issues.apache.org/jira/browse/MESOS-6499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a gauge to track active subscribers.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
>   src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 
> 
> 
> Diff: https://reviews.apache.org/r/53267/diff/2/
> 
> 
> Testing
> ---
> 
> Ran this on master with a client keeps subscribing and disconnecting. 
> Observes that gauge gets updated and new log line is printed.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 53267: Added a gauge to track active subscribers.

2018-04-12 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53267/
---

(Updated April 12, 2018, 2:32 p.m.)


Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Changes
---

Rebase and updated summary.


Summary (updated)
-

Added a gauge to track active subscribers.


Bugs: MESOS-6499
https://issues.apache.org/jira/browse/MESOS-6499


Repository: mesos


Description (updated)
---

Added a gauge to track active subscribers.


Diffs (updated)
-

  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 


Diff: https://reviews.apache.org/r/53267/diff/2/

Changes: https://reviews.apache.org/r/53267/diff/1-2/


Testing
---

Ran this on master with a client keeps subscribing and disconnecting. Observes 
that gauge gets updated and new log line is printed.


Thanks,

Zhitao Li