Re: Review Request 53306: Change unit test function for new user param in prepare func.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Nov. 4, 2016, 2:13 p.m.) Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description --- Change unit test function for new user param in prepare func. Diffs - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
Re: Review Request 53306: Change unit test function for new user param in prepare func.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/#review154366 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos ReviewBot On Oct. 31, 2016, 7:18 p.m., Sivaram Kannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53306/ > --- > > (Updated Oct. 31, 2016, 7:18 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > --- > > Change unit test function for new user param in prepare func. > > > Diffs > - > > src/tests/container_logger_tests.cpp > 1bb94a8461e481983f25a44737e4011ed5fc4b1f > > Diff: https://reviews.apache.org/r/53306/diff/ > > > Testing > --- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh > > > Thanks, > > Sivaram Kannan > >
Re: Review Request 53306: Change unit test function for new user param in prepare func.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53306/ --- (Updated Oct. 31, 2016, 7:18 p.m.) Review request for mesos. Summary (updated) - Change unit test function for new user param in prepare func. Bugs: MESOS-5856 https://issues.apache.org/jira/browse/MESOS-5856 Repository: mesos Description (updated) --- Change unit test function for new user param in prepare func. Diffs (updated) - src/tests/container_logger_tests.cpp 1bb94a8461e481983f25a44737e4011ed5fc4b1f Diff: https://reviews.apache.org/r/53306/diff/ Testing --- 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether the logs are getting rotated. 2. Run the mesos-logrotate-logger as root user and verify whether the logs are getting rotated. 3. Run all the unit test with sudo - sudo bin/mesos-tests.sh Thanks, Sivaram Kannan
