Re: Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53458/
---

(Updated Nov. 29, 2016, 8:21 p.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Repository: mesos


Description
---

Removed `Socket` dependency on `Socket::Impl`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/socket.hpp 
f798af7879546d71e8ef4a295c9cf489a70cb61f 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp 
acb00d41c637a318b2f16fff9e97998b9c79b809 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
5c0929d3d9f5595bd2f343b98b899fd6b06a67b2 
  3rdparty/libprocess/src/poll_socket.cpp 
eb7b48713edd30b545d7be95b5d51b0f71bd422a 
  3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 

Diff: https://reviews.apache.org/r/53458/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Re: Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53458/#review157065
---


Fix it, then Ship it!





3rdparty/libprocess/src/poll_socket.cpp (line 117)


Looks like we consistently use Socket::Impl in libevent_ssl_socket.cpp. Can 
we be consistent and use Socket::Impl in this file as well?


- Jie Yu


On Nov. 28, 2016, 5:38 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53458/
> ---
> 
> (Updated Nov. 28, 2016, 5:38 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed `Socket` dependency on `Socket::Impl`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/socket.hpp 
> f798af7879546d71e8ef4a295c9cf489a70cb61f 
>   3rdparty/libprocess/src/libevent_ssl_socket.hpp 
> acb00d41c637a318b2f16fff9e97998b9c79b809 
>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 
> 5c0929d3d9f5595bd2f343b98b899fd6b06a67b2 
>   3rdparty/libprocess/src/poll_socket.cpp 
> eb7b48713edd30b545d7be95b5d51b0f71bd422a 
>   3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 
> 
> Diff: https://reviews.apache.org/r/53458/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53458/
---

(Updated Nov. 28, 2016, 5:38 a.m.)


Review request for mesos, Benjamin Mahler and Jie Yu.


Changes
---

Removed unused commented code.


Repository: mesos


Description
---

Removed `Socket` dependency on `Socket::Impl`.


Diffs (updated)
-

  3rdparty/libprocess/include/process/socket.hpp 
f798af7879546d71e8ef4a295c9cf489a70cb61f 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp 
acb00d41c637a318b2f16fff9e97998b9c79b809 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
5c0929d3d9f5595bd2f343b98b899fd6b06a67b2 
  3rdparty/libprocess/src/poll_socket.cpp 
eb7b48713edd30b545d7be95b5d51b0f71bd422a 
  3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 

Diff: https://reviews.apache.org/r/53458/diff/


Testing
---

make check


Thanks,

Benjamin Hindman

Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53458/
---

Review request for mesos, Benjamin Mahler and Jie Yu.


Repository: mesos


Description
---

Removed `Socket` dependency on `Socket::Impl`.


Diffs
-

  3rdparty/libprocess/include/process/socket.hpp 
f798af7879546d71e8ef4a295c9cf489a70cb61f 
  3rdparty/libprocess/src/libevent_ssl_socket.hpp 
acb00d41c637a318b2f16fff9e97998b9c79b809 
  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
21f878ee81db32ad35878ec053c3f2de3637196c 
  3rdparty/libprocess/src/poll_socket.cpp 
f0ee1490e6fccb038f64a27b2c71458ad5b5e5a1 
  3rdparty/libprocess/src/socket.cpp 7f93168e1572f8669f67a4c5e6e5467259b7a407 

Diff: https://reviews.apache.org/r/53458/diff/


Testing
---

make check


Thanks,

Benjamin Hindman