Re: Review Request 53532: Added `parse` helper function for `Docker::Device`.

2017-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/#review167471
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:28 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53532/
> ---
> 
> (Updated Nov. 16, 2016, 3:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new helper function to parse a string to `Docker::Device`
> structure. The string should be in the format of
> `PathInHost:PathInContainer:Permission`.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
> 
> 
> Diff: https://reviews.apache.org/r/53532/diff/3/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53532: Added `parse` helper function for `Docker::Device`.

2016-11-15 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/
---

(Updated Nov. 16, 2016, 3:28 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Summary (updated)
-

Added `parse` helper function for `Docker::Device`.


Repository: mesos


Description (updated)
---

Added a new helper function to parse a string to `Docker::Device`
structure. The string should be in the format of
`PathInHost:PathInContainer:Permission`.


Diffs (updated)
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 

Diff: https://reviews.apache.org/r/53532/diff/


Testing
---

make -j4 check


Thanks,

Yubo Li

Re: Review Request 53532: Added parse helper function to 'Docker::Device'.

2016-11-14 Thread Yubo Li 


> On 十一月 12, 2016, 12:26 p.m., Guangya Liu wrote:
> > Summary:
> > ```
> > Added `parse` helper function for `Docker::Device`.
> > ```
> > 
> > Description:
> > ```
> > Added a new helper function to parse a string to 'Docker::Device'
> > 'Docker::Device' structure. The string should be in the format of
> > `PathInHost:PathInContainer:Permission`.
> > ```

fixed


- Yubo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/#review155778
---


On 十一月 10, 2016, 8:14 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53532/
> ---
> 
> (Updated 十一月 10, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function to parse string input to 'Docker::Device'
> structure.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
> 
> Diff: https://reviews.apache.org/r/53532/diff/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53532: Added parse helper function to 'Docker::Device'.

2016-11-12 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/#review155778
---



Summary:
```
Added `parse` helper function for `Docker::Device`.
```

Description:
```
Added a new helper function to parse a string to 'Docker::Device'
'Docker::Device' structure. The string should be in the format of
`PathInHost:PathInContainer:Permission`.
```


src/docker/docker.hpp (line 71)


How about adding a comment here?

```
// Parse a string to docker device, the string should be 
// in the format of `PathInHost:PathInContainer:Permission`.
```


- Guangya Liu


On 十一月 10, 2016, 8:14 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53532/
> ---
> 
> (Updated 十一月 10, 2016, 8:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added helper function to parse string input to 'Docker::Device'
> structure.
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
> 
> Diff: https://reviews.apache.org/r/53532/diff/
> 
> 
> Testing
> ---
> 
> make -j4 check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Re: Review Request 53532: Added parse helper function to 'Docker::Device'.

2016-11-10 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/
---

(Updated Nov. 10, 2016, 8:14 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Repository: mesos


Description
---

Added helper function to parse string input to 'Docker::Device'
structure.


Diffs (updated)
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 

Diff: https://reviews.apache.org/r/53532/diff/


Testing
---

make -j4 check


Thanks,

Yubo Li

Re: Review Request 53532: Added parse helper function to 'Docker::Device'.

2016-11-07 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/
---

(Updated 十一月 7, 2016, 1:59 p.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Repository: mesos


Description
---

Added helper function to parse string input to 'Docker::Device'
structure.


Diffs
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 

Diff: https://reviews.apache.org/r/53532/diff/


Testing (updated)
---

make -j4 check


Thanks,

Yubo Li

Review Request 53532: Added parse helper function to 'Docker::Device'.

2016-11-07 Thread Yubo Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53532/
---

Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Repository: mesos


Description
---

Added helper function to parse string input to 'Docker::Device'
structure.


Diffs
-

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 

Diff: https://reviews.apache.org/r/53532/diff/


Testing
---


Thanks,

Yubo Li