Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.

2017-03-01 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/#review167474
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 16, 2016, 3:29 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53533/
> ---
> 
> (Updated Nov. 16, 2016, 3:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch extended `dockerFlags()` to pass `devices` to
> mesos-docker-executor, and then the `devices` can be used
> by the docker container when mesos-docker-executor starts
> the docker container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> 
> Diff: https://reviews.apache.org/r/53533/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>



Re: Review Request 53533: Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.

2016-11-15 Thread Yubo Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/
---

(Updated Nov. 16, 2016, 3:29 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Summary (updated)
-

Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.


Repository: mesos


Description (updated)
---

This patch extended `dockerFlags()` to pass `devices` to
mesos-docker-executor, and then the `devices` can be used
by the docker container when mesos-docker-executor starts
the docker container.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 

Diff: https://reviews.apache.org/r/53533/diff/


Testing
---

make check


Thanks,

Yubo Li