Re: Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.

2016-11-15 Thread Yubo Li


> On 十一月 12, 2016, 2:20 p.m., Guangya Liu wrote:
> > Summary
> > ```
> > Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.
> > ```
> > 
> > Description
> > ```
> > This patch extended `dockerFlags()` to pass `devices` to
> > mesos-docker-executor, and then the `devices` can be used
> > by the docker container when mesos-docker-executor start
> > the docker container.
> > ```

fixed


- Yubo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/#review155781
---


On 十一月 10, 2016, 8:15 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53533/
> ---
> 
> (Updated 十一月 10, 2016, 8:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extended a new docker flag in docker containerizer to pass devices
> to mesos-docker-executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> Diff: https://reviews.apache.org/r/53533/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>



Re: Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.

2016-11-12 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/#review155781
---



Summary
```
Extended `dockerFlags()` to pass `devices` to mesos-docker-executor.
```

Description
```
This patch extended `dockerFlags()` to pass `devices` to
mesos-docker-executor, and then the `devices` can be used
by the docker container when mesos-docker-executor start
the docker container.
```

- Guangya Liu


On 十一月 10, 2016, 8:15 a.m., Yubo Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53533/
> ---
> 
> (Updated 十一月 10, 2016, 8:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Extended a new docker flag in docker containerizer to pass devices
> to mesos-docker-executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 
> 
> Diff: https://reviews.apache.org/r/53533/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>



Re: Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.

2016-11-10 Thread Yubo Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/
---

(Updated Nov. 10, 2016, 8:15 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Repository: mesos


Description
---

Extended a new docker flag in docker containerizer to pass devices
to mesos-docker-executor.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 

Diff: https://reviews.apache.org/r/53533/diff/


Testing
---

make check


Thanks,

Yubo Li



Review Request 53533: Extended docker flags to pass devices to mesos-docker-executor.

2016-11-07 Thread Yubo Li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53533/
---

Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat 
Phull.


Repository: mesos


Description
---

Extended a new docker flag in docker containerizer to pass devices
to mesos-docker-executor.


Diffs
-

  src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c 

Diff: https://reviews.apache.org/r/53533/diff/


Testing
---

make check


Thanks,

Yubo Li