Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/#review157324 --- Ship it! Ship It! - Kapil Arya On Nov. 29, 2016, 2:54 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54129/ > --- > > (Updated Nov. 29, 2016, 2:54 p.m.) > > > Review request for mesos, Adam B and Kapil Arya. > > > Bugs: MESOS-6650 > https://issues.apache.org/jira/browse/MESOS-6650 > > > Repository: mesos > > > Description > --- > > see summary. > > > Diffs > - > > include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 > src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f > src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 > src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b > src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 > src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f25ee3fa2 > > Diff: https://reviews.apache.org/r/54129/diff/ > > > Testing > --- > > make check > > > Thanks, > > Till Toenshoff > >
Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/ --- (Updated Nov. 29, 2016, 7:54 p.m.) Review request for mesos, Adam B and Kapil Arya. Bugs: MESOS-6650 https://issues.apache.org/jira/browse/MESOS-6650 Repository: mesos Description --- see summary. Diffs - include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f25ee3fa2 Diff: https://reviews.apache.org/r/54129/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/ --- (Updated Nov. 29, 2016, 7:52 p.m.) Review request for mesos, Adam B and Kapil Arya. Summary (updated) - Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook. Bugs: MESOS-6396 https://issues.apache.org/jira/browse/MESOS-6396 Repository: mesos Description --- see summary. Diffs (updated) - include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f25ee3fa2 Diff: https://reviews.apache.org/r/54129/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/#review157105 --- Patch looks great! Reviews applied: [54038, 54068, 54128, 54129] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Nov. 28, 2016, 3:53 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54129/ > --- > > (Updated Nov. 28, 2016, 3:53 p.m.) > > > Review request for mesos, Adam B and Kapil Arya. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > --- > > see summary. > > > Diffs > - > > include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 > src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e > src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > src/slave/containerizer/docker.cpp a8e522fc058f50560e8ec162c31be079e620bf9d > src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f25ee3fa2 > > Diff: https://reviews.apache.org/r/54129/diff/ > > > Testing > --- > > make check > > > Thanks, > > Till Toenshoff > >
Review Request 54129: Removed superseded `slavePreLaunchDockerEnvironmentDecorator` hook .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54129/ --- Review request for mesos, Adam B and Kapil Arya. Bugs: MESOS-6396 https://issues.apache.org/jira/browse/MESOS-6396 Repository: mesos Description --- see summary. Diffs - include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 src/examples/test_hook_module.cpp 5e91a71f2450cf3c37eb9039ef28c026095c917e src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 src/slave/containerizer/docker.cpp a8e522fc058f50560e8ec162c31be079e620bf9d src/tests/hook_tests.cpp d334d6c5ff7f966d55b395bfbf4f25ee3fa2 Diff: https://reviews.apache.org/r/54129/diff/ Testing --- make check Thanks, Till Toenshoff
