Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

2016-11-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54174/#review157364
---



Bad patch!

Reviews applied: [54174, 54165, 54129, 54128, 54068, 54038]

Failed command: ./support/apply-review.sh -n -r 54128

Error:
2016-11-30 03:49:21 URL:https://reviews.apache.org/r/54128/diff/raw/ 
[5352/5352] -> "54128.patch" [1]
error: patch failed: src/examples/test_hook_module.cpp:217
error: src/examples/test_hook_module.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/16269/console

- Mesos ReviewBot


On Nov. 29, 2016, 7:54 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54174/
> ---
> 
> (Updated Nov. 29, 2016, 7:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-6650
> https://issues.apache.org/jira/browse/MESOS-6650
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 
>   src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f 
>   src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 
>   src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b 
>   src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 
> 
> Diff: https://reviews.apache.org/r/54174/diff/
> 
> 
> Testing
> ---
> 
> make check and sudo tests
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

2016-11-29 Thread Till Toenshoff 


> On Nov. 29, 2016, 8:37 p.m., Kapil Arya wrote:
> > src/examples/test_hook_module.cpp, line 228
> > 
> >
> > Do we have a test where we are testing for the presence of `foo`?

`HookTest.ROOT_DOCKER_VerifySlavePreLaunchDockerHook` - see 
https://github.com/apache/mesos/blob/a85e284013a10e0ca036ab16128530c8cfd17087/src/tests/hook_tests.cpp#L899


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54174/#review157322
---


On Nov. 29, 2016, 7:54 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54174/
> ---
> 
> (Updated Nov. 29, 2016, 7:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-6650
> https://issues.apache.org/jira/browse/MESOS-6650
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 
>   src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f 
>   src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 
>   src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b 
>   src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 
> 
> Diff: https://reviews.apache.org/r/54174/diff/
> 
> 
> Testing
> ---
> 
> make check and sudo tests
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

2016-11-29 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54174/#review157322
---


Fix it, then Ship it!




Ship It!


src/examples/test_hook_module.cpp (line 228)


Do we have a test where we are testing for the presence of `foo`?


- Kapil Arya


On Nov. 29, 2016, 2:54 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54174/
> ---
> 
> (Updated Nov. 29, 2016, 2:54 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-6650
> https://issues.apache.org/jira/browse/MESOS-6650
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 
>   src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f 
>   src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 
>   src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b 
>   src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 
> 
> Diff: https://reviews.apache.org/r/54174/diff/
> 
> 
> Testing
> ---
> 
> make check and sudo tests
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

2016-11-29 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54174/
---

(Updated Nov. 29, 2016, 7:54 p.m.)


Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil 
Arya.


Bugs: MESOS-6650
https://issues.apache.org/jira/browse/MESOS-6650


Repository: mesos


Description
---

see summary.


Diffs
-

  include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 
  src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f 
  src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 
  src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b 
  src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 

Diff: https://reviews.apache.org/r/54174/diff/


Testing
---

make check and sudo tests


Thanks,

Till Toenshoff

Review Request 54174: Removed superseded `slavePreLaunchDockerHook` hook.

2016-11-29 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54174/
---

Review request for mesos, Adam B, Benjamin Bannier, Gastón Kleiman, and Kapil 
Arya.


Repository: mesos


Description
---

see summary.


Diffs
-

  include/mesos/hook.hpp 134951ca5ee60d0cfb3cacd5ba2ae26420570d29 
  src/examples/test_hook_module.cpp 094a92b8133f4be3d9533510863d3361e0e9d23f 
  src/hook/manager.hpp ad52717fb043d03ca29063727656ebe1bbf55114 
  src/hook/manager.cpp 59f402b1f8f076b151b771b2b1ae89a3b4d34d5b 
  src/slave/containerizer/docker.cpp 5ce4667b61bb226f726beda6e21b839456e0b941 

Diff: https://reviews.apache.org/r/54174/diff/


Testing
---

make check and sudo tests


Thanks,

Till Toenshoff