Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-04 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/
---

(Updated Dec. 5, 2016, 7:09 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase on master.


Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470


Repository: mesos


Description
---

Added `setWindowSize()` to stout for setting a TTY's window size.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/os.hpp 
09196be9d359ef79c9cbafeec25d965f2db35d42 

Diff: https://reviews.apache.org/r/54344/diff/


Testing
---

make check


Thanks,

Kevin Klues



Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-04 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/
---

(Updated Dec. 5, 2016, 7:06 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased on master.


Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470


Repository: mesos


Description
---

Added `setWindowSize()` to stout for setting a TTY's window size.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/os.hpp 
09196be9d359ef79c9cbafeec25d965f2db35d42 

Diff: https://reviews.apache.org/r/54344/diff/


Testing
---

make check


Thanks,

Kevin Klues



Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-04 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/
---

(Updated Dec. 5, 2016, 12:41 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6470
https://issues.apache.org/jira/browse/MESOS-6470


Repository: mesos


Description
---

Added `setWindowSize()` to stout for setting a TTY's window size.


Diffs
-

  3rdparty/stout/include/stout/posix/os.hpp 
c37e64db662ba3cee83d2f55de0f9d71ad72c038 

Diff: https://reviews.apache.org/r/54344/diff/


Testing
---

make check


Thanks,

Kevin Klues



Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-03 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/
---

(Updated Dec. 4, 2016, 12:56 a.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added `setWindowSize()` to stout for setting a TTY's window size.


Diffs
-

  3rdparty/stout/include/stout/posix/os.hpp 
c37e64db662ba3cee83d2f55de0f9d71ad72c038 

Diff: https://reviews.apache.org/r/54344/diff/


Testing
---

make check


Thanks,

Kevin Klues



Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-03 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/
---

(Updated Dec. 4, 2016, 12:53 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Updated to remove circular dependency in reviews.


Repository: mesos


Description
---

Added `setWindowSize()` to stout for setting a TTY's window size.


Diffs (updated)
-

  3rdparty/stout/include/stout/posix/os.hpp 
c37e64db662ba3cee83d2f55de0f9d71ad72c038 

Diff: https://reviews.apache.org/r/54344/diff/


Testing
---

make check


Thanks,

Kevin Klues



Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-03 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/#review157912
---



Patch looks great!

Reviews applied: [54274, 54296, 54297, 54344]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Dec. 3, 2016, 7:57 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54344/
> ---
> 
> (Updated Dec. 3, 2016, 7:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `setWindowSize()` to stout for setting a TTY's window size.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/os.hpp 
> c37e64db662ba3cee83d2f55de0f9d71ad72c038 
> 
> Diff: https://reviews.apache.org/r/54344/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-03 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/#review157906
---


Ship it!




Ship It!

- Jie Yu


On Dec. 3, 2016, 7:57 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54344/
> ---
> 
> (Updated Dec. 3, 2016, 7:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `setWindowSize()` to stout for setting a TTY's window size.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/os.hpp 
> c37e64db662ba3cee83d2f55de0f9d71ad72c038 
> 
> Diff: https://reviews.apache.org/r/54344/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Review Request 54344: Added `setWindowSize()` to stout for setting a TTY's window size.

2016-12-03 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54344/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added `setWindowSize()` to stout for setting a TTY's window size.


Diffs
-

  3rdparty/stout/include/stout/posix/os.hpp 
c37e64db662ba3cee83d2f55de0f9d71ad72c038 

Diff: https://reviews.apache.org/r/54344/diff/


Testing
---

make check


Thanks,

Kevin Klues