Re: Review Request 54731: Fixed a check bug in LAUNCH_NESTED_CONTAINER_SESSION_CALL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54731/#review159108 --- Ship it! Ship It! - Adam B On Dec. 13, 2016, 8:15 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54731/ > --- > > (Updated Dec. 13, 2016, 8:15 p.m.) > > > Review request for mesos, Adam B and Kevin Klues. > > > Repository: mesos > > > Description > --- > > `attachContainerOutput` could return a non OK response (e.g., authz > error). We should return the response in this case instead of failing > the CHECK. > > > Diffs > - > > src/slave/http.cpp 56c2879c41a84f959107e28410a46aeb11457975 > > Diff: https://reviews.apache.org/r/54731/diff/ > > > Testing > --- > > I will add a test in the next review. > > > Thanks, > > Vinod Kone > >
Re: Review Request 54731: Fixed a check bug in LAUNCH_NESTED_CONTAINER_SESSION_CALL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54731/#review159109 --- Ship it! Ship It! - Kevin Klues On Dec. 14, 2016, 4:15 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54731/ > --- > > (Updated Dec. 14, 2016, 4:15 a.m.) > > > Review request for mesos, Adam B and Kevin Klues. > > > Repository: mesos > > > Description > --- > > `attachContainerOutput` could return a non OK response (e.g., authz > error). We should return the response in this case instead of failing > the CHECK. > > > Diffs > - > > src/slave/http.cpp 56c2879c41a84f959107e28410a46aeb11457975 > > Diff: https://reviews.apache.org/r/54731/diff/ > > > Testing > --- > > I will add a test in the next review. > > > Thanks, > > Vinod Kone > >
Review Request 54731: Fixed a check bug in LAUNCH_NESTED_CONTAINER_SESSION_CALL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54731/ --- Review request for mesos, Adam B and Kevin Klues. Repository: mesos Description --- `attachContainerOutput` could return a non OK response (e.g., authz error). We should return the response in this case instead of failing the CHECK. Diffs - src/slave/http.cpp 56c2879c41a84f959107e28410a46aeb11457975 Diff: https://reviews.apache.org/r/54731/diff/ Testing --- I will add a test in the next review. Thanks, Vinod Kone
