Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
> On Jan. 17, 2017, 1:30 p.m., Benjamin Mahler wrote: > > With respect to the comment, do you know when this check would fail? > > > > E.g. if an agent >= 0.24.0 registers the check holds > > > > Since by committing this I'm taking accountability of it being safe, it > > would be great if you could quickly convince me that you did your homework. > > :) > > Jay Guo wrote: > OK let me try to explain. The whole idea is to replace `framework_id` in > favor of `FrameworkInfo.id()` so we could deprecate > `RunTaskMessage.FrameworkID`. > > Prior to 0.24.0, when the master sends `RunTaskMessage` to an agent, it > may not have `FrameworkID` in `FrameworkInfo`. In this case, when a master > re-construct `FrameworkInfo` after a failover from agent's `FrameworkInfo`, > it does *NOT* have `FrameworkID`. > > With MESOS-905 being fixed, we garantee that `FrameworkInfo` always > contains `FrameworkID`, thus this `CHECK` holds. > > Does this make sense at all? Please let me know if I'm missing someting > here since there's quite some history to dig up. This seems accurate to me. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review161959 --- On Jan. 12, 2017, 12:57 a.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54898/ > --- > > (Updated Jan. 12, 2017, 12:57 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added a CHECK in updateFrameworkInfo. > > > Diffs > - > > src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 > > Diff: https://reviews.apache.org/r/54898/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jay Guo > >
Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review162767 --- Ship it! Ship It! - Michael Park On Jan. 12, 2017, 12:57 a.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54898/ > --- > > (Updated Jan. 12, 2017, 12:57 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added a CHECK in updateFrameworkInfo. > > > Diffs > - > > src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 > > Diff: https://reviews.apache.org/r/54898/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jay Guo > >
Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
> On Jan. 18, 2017, 5:30 a.m., Benjamin Mahler wrote: > > With respect to the comment, do you know when this check would fail? > > > > E.g. if an agent >= 0.24.0 registers the check holds > > > > Since by committing this I'm taking accountability of it being safe, it > > would be great if you could quickly convince me that you did your homework. > > :) OK let me try to explain. The whole idea is to replace `framework_id` in favor of `FrameworkInfo.id()` so we could deprecate `RunTaskMessage.FrameworkID`. Prior to 0.24.0, when the master sends `RunTaskMessage` to an agent, it may not have `FrameworkID` in `FrameworkInfo`. In this case, when a master re-construct `FrameworkInfo` after a failover from agent's `FrameworkInfo`, it does *NOT* have `FrameworkID`. With MESOS-905 being fixed, we garantee that `FrameworkInfo` always contains `FrameworkID`, thus this `CHECK` holds. Does this make sense at all? Please let me know if I'm missing someting here since there's quite some history to dig up. - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review161959 --- On Jan. 12, 2017, 4:57 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54898/ > --- > > (Updated Jan. 12, 2017, 4:57 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added a CHECK in updateFrameworkInfo. > > > Diffs > - > > src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 > > Diff: https://reviews.apache.org/r/54898/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jay Guo > >
Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review161959 --- With respect to the comment, do you know when this check would fail? E.g. if an agent >= 0.24.0 registers the check holds Since by committing this I'm taking accountability of it being safe, it would be great if you could quickly convince me that you did your homework. :) - Benjamin Mahler On Jan. 12, 2017, 8:57 a.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54898/ > --- > > (Updated Jan. 12, 2017, 8:57 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > --- > > Added a CHECK in updateFrameworkInfo. > > > Diffs > - > > src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 > > Diff: https://reviews.apache.org/r/54898/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jay Guo > >
Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/ --- (Updated Jan. 12, 2017, 4:57 p.m.) Review request for mesos, Benjamin Mahler, Guangya Liu, and Joris Van Remoortere. Changes --- rebase Repository: mesos Description --- Added a CHECK in updateFrameworkInfo. Diffs (updated) - src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 Diff: https://reviews.apache.org/r/54898/diff/ Testing --- make check Thanks, Jay Guo
Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review160816 --- Ship it! Ship It! - Guangya Liu On 十二月 20, 2016, 3:06 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54898/ > --- > > (Updated 十二月 20, 2016, 3:06 p.m.) > > > Review request for mesos, Guangya Liu and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Added a CHECK in updateFrameworkInfo. > > > Diffs > - > > src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 > > Diff: https://reviews.apache.org/r/54898/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jay Guo > >
Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/#review159796 --- Patch looks great! Reviews applied: [54898] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Dec. 20, 2016, 3:06 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54898/ > --- > > (Updated Dec. 20, 2016, 3:06 p.m.) > > > Review request for mesos, Guangya Liu and Joris Van Remoortere. > > > Repository: mesos > > > Description > --- > > Added a CHECK in updateFrameworkInfo. > > > Diffs > - > > src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 > > Diff: https://reviews.apache.org/r/54898/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jay Guo > >
Review Request 54898: Added a CHECK in updateFrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/ --- Review request for mesos, Guangya Liu and Joris Van Remoortere. Repository: mesos Description --- Added a CHECK in updateFrameworkInfo. Diffs - src/master/master.hpp 89b3c394b268a8645885412aeb19980db8d73c69 Diff: https://reviews.apache.org/r/54898/diff/ Testing --- make check Thanks, Jay Guo
