Re: Review Request 55602: CMake: Added source groups for master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55602/ --- (Updated Jan. 17, 2017, 6:41 a.m.) Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Changes --- Fixup file matching pattern. Bugs: MESOS-3542 https://issues.apache.org/jira/browse/MESOS-3542 Repository: mesos Description --- This commit will continue our effort to break libmesos into a modular set of libraries that can be built and linked independently, and away from the approach of creating a single, monolithic libmesos library. This effort is tracked in MESOS-3542. This commit will specifically address the problem of breaking master code into a self-contained source group, which can then be exported as its own library. This code also has the benefit of making IDEs display the master code in a hierarchical directory structure. Diffs (updated) - src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c src/master/cmake/MasterSourceList.cmake PRE-CREATION Diff: https://reviews.apache.org/r/55602/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 55602: CMake: Added source groups for master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55602/#review161818 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55030, 55037, 55038, 55039, 55040, 55161, 55162, 55311, 55312, 55313, 55314, 55327, 55328, 55543, 55544, 55546, 55547, 55548, 55549, 0, 55599, 55600, 55601, 55602] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos ReviewBot On Jan. 17, 2017, 4:37 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55602/ > --- > > (Updated Jan. 17, 2017, 4:37 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-3542 > https://issues.apache.org/jira/browse/MESOS-3542 > > > Repository: mesos > > > Description > --- > > This commit will continue our effort to break libmesos into a modular > set of libraries that can be built and linked independently, and away > from the approach of creating a single, monolithic libmesos library. > This effort is tracked in MESOS-3542. > > This commit will specifically address the problem of breaking master > code into a self-contained source group, which can then be exported as > its own library. This code also has the benefit of making IDEs display > the master code in a hierarchical directory structure. > > > Diffs > - > > src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c > src/master/cmake/MasterSourceList.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/55602/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Review Request 55602: CMake: Added source groups for master.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55602/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Bugs: MESOS-3542 https://issues.apache.org/jira/browse/MESOS-3542 Repository: mesos Description --- This commit will continue our effort to break libmesos into a modular set of libraries that can be built and linked independently, and away from the approach of creating a single, monolithic libmesos library. This effort is tracked in MESOS-3542. This commit will specifically address the problem of breaking master code into a self-contained source group, which can then be exported as its own library. This code also has the benefit of making IDEs display the master code in a hierarchical directory structure. Diffs - src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c src/master/cmake/MasterSourceList.cmake PRE-CREATION Diff: https://reviews.apache.org/r/55602/diff/ Testing --- Thanks, Alex Clemmer
