Re: Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55604/#review161824 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55030, 55037, 55038, 55039, 55040, 55161, 55162, 55311, 55312, 55313, 55314, 55327, 55328, 55543, 55544, 55546, 55547, 55548, 55549, 0, 55599, 55600, 55601, 55602, 55604] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos ReviewBot On Jan. 17, 2017, 6:42 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55604/ > --- > > (Updated Jan. 17, 2017, 6:42 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-3542 > https://issues.apache.org/jira/browse/MESOS-3542 > > > Repository: mesos > > > Description > --- > > Libprocess currently manually groups its source code by folder in order > to present the source nicely in IDEs like XCode and Visual Studio. > > With the recently-introduced CMake function, `GROUP_SOURCE`, this > process is automated away. This commit will remove these manual groups > and replace it with a call to this function. > > > Diffs > - > > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 873f41d844faa0d442f77411e94314a89be5f046 > 3rdparty/libprocess/src/CMakeLists.txt > 60f0e76dfd237d9a12a366b413802d1a96892b55 > 3rdparty/libprocess/src/tests/CMakeLists.txt > 0b2660cb16f5d8d8dc66e6995061d0b832182351 > > Diff: https://reviews.apache.org/r/55604/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55604/ --- (Updated Jan. 17, 2017, 6:42 a.m.) Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Changes --- Fixup file matching pattern. Bugs: MESOS-3542 https://issues.apache.org/jira/browse/MESOS-3542 Repository: mesos Description --- Libprocess currently manually groups its source code by folder in order to present the source nicely in IDEs like XCode and Visual Studio. With the recently-introduced CMake function, `GROUP_SOURCE`, this process is automated away. This commit will remove these manual groups and replace it with a call to this function. Diffs (updated) - 3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046 3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55 3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351 Diff: https://reviews.apache.org/r/55604/diff/ Testing --- Thanks, Alex Clemmer
Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55604/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. Bugs: MESOS-3542 https://issues.apache.org/jira/browse/MESOS-3542 Repository: mesos Description --- Libprocess currently manually groups its source code by folder in order to present the source nicely in IDEs like XCode and Visual Studio. With the recently-introduced CMake function, `GROUP_SOURCE`, this process is automated away. This commit will remove these manual groups and replace it with a call to this function. Diffs - 3rdparty/libprocess/cmake/ProcessConfigure.cmake 873f41d844faa0d442f77411e94314a89be5f046 3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55 3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351 Diff: https://reviews.apache.org/r/55604/diff/ Testing --- Thanks, Alex Clemmer
