---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55695/#review163369
---
Ship it!
LGTM.
- Joseph Wu
On Jan. 18, 2017, 5:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55695/
> ---
>
> (Updated Jan. 18, 2017, 5:23 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-3932
> https://issues.apache.org/jira/browse/MESOS-3932
>
>
> Repository: mesos
>
>
> Description
> ---
>
> MESOS-3932 specifies a bug that causes spurious warnings to be printed
> when building Mesos.
>
> Many of these warnings can be eliminated simply by correctly marking off
> the third-party dependencies as `SYSTEM` headers when we specify the
> include path.
>
> This commit will thus separate out the headers of Libprocesses's
> third-party dependencies from the core Libprocess API headers, and
> include them as `SYSTEM` headers.
>
> Notably, we choose to include Stout's headers as third-party system
> headers, since the goal is for them to be completely independent
> projects.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake
> 873f41d844faa0d442f77411e94314a89be5f046
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
> 49ad836d5fa3f84cdf5ae0e08f449cd7ef2537a1
> 3rdparty/libprocess/src/CMakeLists.txt
> 60f0e76dfd237d9a12a366b413802d1a96892b55
>
> Diff: https://reviews.apache.org/r/55695/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Alex Clemmer
>
>
