Re: Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56037/#review163374 --- Ship it! Ship It! - Joseph Wu On Jan. 27, 2017, 12:45 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56037/ > --- > > (Updated Jan. 27, 2017, 12:45 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > This commit will bump the required CMake version on Windows from ~3.5 to > 3.6.3, and then add a configure-time check to ensure that this is true > before we build. > > On Windows, bumping the required version is much less of a big deal than > Unix, mainly because Windows does not have a package manager. The burden > on developers is about the same, independent of the version, because the > most convenient installation option is to use a `.msi`. Additionally, > CMake is not widely used in the community, and where it is, the vast > majority of users are building on Unix, so there are few constraints > imposed by existing CI systems and users. > > The primary reason to bump the version, though, is that the CMake > featureset on Windows tends (consciously or not) to straggle a bit > behind the Unix featureset, and recently it has come to our attention > that (due to our ignorance of this issue) we have come to depend on some > subtle features that are available on Unix, but not on Windows, until > CMake 3.6.3. > > > Diffs > - > > CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f > docs/windows.md 5a5f934180f11fd6260032551f0df65fde541218 > > Diff: https://reviews.apache.org/r/56037/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56037/#review163330 --- Bad patch! Reviews applied: [56037, 55749, 55748, 55696, 55695, 55694, 55637, 55632, 55607, 55604, 55602, 55601, 55600, 55599, 0, 55549, 55547, 55546, 55544, 55543, 55328, 55327, 55314, 55313, 55312, 55311, 55162, 55161, 55040, 55039, 55038, 55037, 55699, 55030, 55024, 55023, 55022] Failed command: python support/apply-reviews.py -n -r 55601 Error: 2017-01-27 21:26:20 URL:https://reviews.apache.org/r/55601/diff/raw/ [23809/23809] -> "55601.patch" [1] error: patch failed: src/CMakeLists.txt:268 error: src/CMakeLists.txt: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/16879/console - Mesos Reviewbot On Jan. 27, 2017, 8:45 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56037/ > --- > > (Updated Jan. 27, 2017, 8:45 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > This commit will bump the required CMake version on Windows from ~3.5 to > 3.6.3, and then add a configure-time check to ensure that this is true > before we build. > > On Windows, bumping the required version is much less of a big deal than > Unix, mainly because Windows does not have a package manager. The burden > on developers is about the same, independent of the version, because the > most convenient installation option is to use a `.msi`. Additionally, > CMake is not widely used in the community, and where it is, the vast > majority of users are building on Unix, so there are few constraints > imposed by existing CI systems and users. > > The primary reason to bump the version, though, is that the CMake > featureset on Windows tends (consciously or not) to straggle a bit > behind the Unix featureset, and recently it has come to our attention > that (due to our ignorance of this issue) we have come to depend on some > subtle features that are available on Unix, but not on Windows, until > CMake 3.6.3. > > > Diffs > - > > CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f > docs/windows.md 5a5f934180f11fd6260032551f0df65fde541218 > > Diff: https://reviews.apache.org/r/56037/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56037/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository: mesos Description --- This commit will bump the required CMake version on Windows from ~3.5 to 3.6.3, and then add a configure-time check to ensure that this is true before we build. On Windows, bumping the required version is much less of a big deal than Unix, mainly because Windows does not have a package manager. The burden on developers is about the same, independent of the version, because the most convenient installation option is to use a `.msi`. Additionally, CMake is not widely used in the community, and where it is, the vast majority of users are building on Unix, so there are few constraints imposed by existing CI systems and users. The primary reason to bump the version, though, is that the CMake featureset on Windows tends (consciously or not) to straggle a bit behind the Unix featureset, and recently it has come to our attention that (due to our ignorance of this issue) we have come to depend on some subtle features that are available on Unix, but not on Windows, until CMake 3.6.3. Diffs - CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f docs/windows.md 5a5f934180f11fd6260032551f0df65fde541218 Diff: https://reviews.apache.org/r/56037/diff/ Testing --- Thanks, Alex Clemmer