Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57730/
---

(Updated April 20, 2017, 10:10 p.m.)


Review request for mesos and Anindya Sinha.


Changes
---

Comments.


Bugs: MESOS-7097
https://issues.apache.org/jira/browse/MESOS-7097


Repository: mesos


Description
---

- With the new `register_agents` ACL, `permissive == false` would lead
  to the agent unable to register unless explicitly allowed.


Diffs (updated)
-

  src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 


Diff: https://reviews.apache.org/r/57730/diff/2/

Changes: https://reviews.apache.org/r/57730/diff/1-2/


Testing
---

make check


Thanks,

Jiang Yan Xu

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

[Jiang Yan Xu]

> On April 11, 2017, 2:11 a.m., Adam B wrote:
> > src/tests/script.cpp
> > Lines 161 (patched)
> > 
> >
> > We don't even enable agent authentication in most(/any?) tests, so I'd 
> > expect the agents to try to register without authentication. Should we 
> > enable agent authentication (and authorization) by default in the tests, 
> > and only disable it for the rare few tests that don't need it?
> 
> Jiang Yan Xu wrote:
> Good point but this patch allows the current tests to run without making 
> things worse. For this improvement we should probably separate the agent 
> credentials and the framework credentials in the examples which I am happy to 
> do. A TODO here and a followup patch sound good?

Updated comments and filed https://issues.apache.org/jira/browse/MESOS-7408 to 
track.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57730/#review171536
---


On April 20, 2017, 10:10 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57730/
> ---
> 
> (Updated April 20, 2017, 10:10 p.m.)
> 
> 
> Review request for mesos and Anindya Sinha.
> 
> 
> Bugs: MESOS-7097
> https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - With the new `register_agents` ACL, `permissive == false` would lead
>   to the agent unable to register unless explicitly allowed.
> 
> 
> Diffs
> -
> 
>   src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 
> 
> 
> Diff: https://reviews.apache.org/r/57730/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

[Jiang Yan Xu]

> On April 11, 2017, 2:11 a.m., Adam B wrote:
> > src/tests/script.cpp
> > Lines 161 (patched)
> > 
> >
> > We don't even enable agent authentication in most(/any?) tests, so I'd 
> > expect the agents to try to register without authentication. Should we 
> > enable agent authentication (and authorization) by default in the tests, 
> > and only disable it for the rare few tests that don't need it?

Good point but this patch allows the current tests to run without making things 
worse. For this improvement we should probably separate the agent credentials 
and the framework credentials in the examples which I am happy to do. A TODO 
here and a followup patch sound good?


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57730/#review171536
---


On March 17, 2017, 8:53 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57730/
> ---
> 
> (Updated March 17, 2017, 8:53 a.m.)
> 
> 
> Review request for mesos and Anindya Sinha.
> 
> 
> Bugs: MESOS-7097
> https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - With the new `register_agents` ACL, `permissive == false` would lead
>   to the agent unable to register unless explicitly allowed.
> 
> 
> Diffs
> -
> 
>   src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 
> 
> 
> Diff: https://reviews.apache.org/r/57730/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57730/#review171536
---




src/tests/script.cpp
Lines 161 (patched)


We don't even enable agent authentication in most(/any?) tests, so I'd 
expect the agents to try to register without authentication. Should we enable 
agent authentication (and authorization) by default in the tests, and only 
disable it for the rare few tests that don't need it?


- Adam B


On March 17, 2017, 8:53 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57730/
> ---
> 
> (Updated March 17, 2017, 8:53 a.m.)
> 
> 
> Review request for mesos and Anindya Sinha.
> 
> 
> Bugs: MESOS-7097
> https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - With the new `register_agents` ACL, `permissive == false` would lead
>   to the agent unable to register unless explicitly allowed.
> 
> 
> Diffs
> -
> 
>   src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 
> 
> 
> Diff: https://reviews.apache.org/r/57730/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57730/#review171024
---


Ship it!




Ship It!

- Greg Mann


On March 17, 2017, 3:53 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57730/
> ---
> 
> (Updated March 17, 2017, 3:53 p.m.)
> 
> 
> Review request for mesos and Anindya Sinha.
> 
> 
> Bugs: MESOS-7097
> https://issues.apache.org/jira/browse/MESOS-7097
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - With the new `register_agents` ACL, `permissive == false` would lead
>   to the agent unable to register unless explicitly allowed.
> 
> 
> Diffs
> -
> 
>   src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 
> 
> 
> Diff: https://reviews.apache.org/r/57730/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57730/
---

Review request for mesos and Anindya Sinha.


Bugs: MESOS-7097
https://issues.apache.org/jira/browse/MESOS-7097


Repository: mesos


Description
---

- With the new `register_agents` ACL, `permissive == false` would lead
  to the agent unable to register unless explicitly allowed.


Diffs
-

  src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 


Diff: https://reviews.apache.org/r/57730/diff/1/


Testing
---

make check


Thanks,

Jiang Yan Xu