Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-07-06 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated July 6, 2017, 11:34 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Addressed BenH's comments.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added storage for IPv6 in a `libprocess` process.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp b3d55390293a11a0ea80f0545a03f8aae04abb81 


Diff: https://reviews.apache.org/r/59130/diff/7/

Changes: https://reviews.apache.org/r/59130/diff/6-7/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-07-05 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/#review179690
---


Fix it, then Ship it!





3rdparty/libprocess/src/process.cpp
Line 170 (original), 172 (patched)


I like the way you did this where you validated that it's an `IPv4` below 
but still take the type `IP`, so let's not label this description as "IPv4" but 
keep it at "IP".



3rdparty/libprocess/src/process.cpp
Lines 1392-1393 (patched)


Can we move this up to just below where we reset `__address__` please? 
Thanks!


- Benjamin Hindman


On June 29, 2017, 11:22 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59130/
> ---
> 
> (Updated June 29, 2017, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added storage for IPv6 in a `libprocess` process.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 8ff37d1b5781c42f96be2da391ed000158eea7b8 
> 
> 
> Diff: https://reviews.apache.org/r/59130/diff/6/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-06-29 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated June 29, 2017, 11:22 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added storage for IPv6 in a `libprocess` process.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 


Diff: https://reviews.apache.org/r/59130/diff/6/

Changes: https://reviews.apache.org/r/59130/diff/5-6/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-06-29 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated June 29, 2017, 11:16 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added storage for IPv6 in a `libprocess` process.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 8ff37d1b5781c42f96be2da391ed000158eea7b8 


Diff: https://reviews.apache.org/r/59130/diff/5/

Changes: https://reviews.apache.org/r/59130/diff/4-5/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-06-16 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated June 16, 2017, 4:36 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased and addressed BenH's comemnts.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description (updated)
---

Added storage for IPv6 in a `libprocess` process.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 2a19078205e4f758edac868d4d5894a6b04d3cd9 


Diff: https://reviews.apache.org/r/59130/diff/4/

Changes: https://reviews.apache.org/r/59130/diff/3-4/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-06-01 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated June 2, 2017, 3:22 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

The operator can specify a v6 address to be used by a `libprocess`
process by specifying the `LIBPROCESS_IP6` environment variable.
Currently the `lipbrocess` stores the IPv6 address but doesn't open a
socket on the v6 address in order to listen or send traffic on the v6
address.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 


Diff: https://reviews.apache.org/r/59130/diff/3/

Changes: https://reviews.apache.org/r/59130/diff/2-3/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-05-31 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

(Updated May 31, 2017, 6:40 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

The operator can specify a v6 address to be used by a `libprocess`
process by specifying the `LIBPROCESS_IP6` environment variable.
Currently the `lipbrocess` stores the IPv6 address but doesn't open a
socket on the v6 address in order to listen or send traffic on the v6
address.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 


Diff: https://reviews.apache.org/r/59130/diff/2/

Changes: https://reviews.apache.org/r/59130/diff/1-2/


Testing
---

make check.


Thanks,

Avinash sridharan

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-05-25 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/#review176155
---




3rdparty/libprocess/src/process.cpp
Lines 119 (patched)


Let's be explicit and add namespace `inet` too so that the code is very 
clear when we're working with v4 versus v6.



3rdparty/libprocess/src/process.cpp
Line 584 (original), 592 (patched)


Do we want a inline struct of `addresses`?

__addresses__.inet6 ? .v4?
.unix

?


- Benjamin Hindman


On May 10, 2017, 7:08 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59130/
> ---
> 
> (Updated May 10, 2017, 7:08 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The operator can specify a v6 address to be used by a `libprocess`
> process by specifying the `LIBPROCESS_IP6` environment variable.
> Currently the `lipbrocess` stores the IPv6 address but doesn't open a
> socket on the v6 address in order to listen or send traffic on the v6
> address.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 
> 
> 
> Diff: https://reviews.apache.org/r/59130/diff/1/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-05-10 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59130/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

The operator can specify a v6 address to be used by a `libprocess`
process by specifying the `LIBPROCESS_IP6` environment variable.
Currently the `lipbrocess` stores the IPv6 address but doesn't open a
socket on the v6 address in order to listen or send traffic on the v6
address.


Diffs
-

  3rdparty/libprocess/src/process.cpp 96ce7dbc486a2f1d55d2238a8a102bf024b12b1c 


Diff: https://reviews.apache.org/r/59130/diff/1/


Testing
---

make check.


Thanks,

Avinash sridharan