Re: Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59203/#review175131 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 11, 2017, 8:09 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59203/ > --- > > (Updated May 11, 2017, 8:09 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-5938 > https://issues.apache.org/jira/browse/MESOS-5938 > > > Repository: mesos > > > Description > --- > > Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform. > > > Diffs > - > > 3rdparty/stout/tests/ip_tests.cpp 4c6f81bd53413360182b447ddb149a18e406870e > 3rdparty/stout/tests/mac_tests.cpp d4560e75ae4e03d1765c599298e88842381690b9 > > > Diff: https://reviews.apache.org/r/59203/diff/1/ > > > Testing > --- > > On Linux, did a 'make check' and insured that all tests (particularly stout > tests, where the work was performed) passed. > > On Windows, did the rough equivalent. Here's relevant output from the Windows > stout-tests.exe program: > > [--] 8 tests from NetTest > **[ RUN ] NetTest.LinkDevice > [ OK ] NetTest.LinkDevice (4 ms)** > [ RUN ] NetTest.ConstructIPv4 > [ OK ] NetTest.ConstructIPv4 (1 ms) > [ RUN ] NetTest.ConstructIPv6 > [ OK ] NetTest.ConstructIPv6 (0 ms) > [ RUN ] NetTest.ConstructIPv4Network > [ OK ] NetTest.ConstructIPv4Network (0 ms) > [ RUN ] NetTest.ConstructIPv6Network > [ OK ] NetTest.ConstructIPv6Network (0 ms) > **[ RUN ] NetTest.Mac > [ OK ] NetTest.Mac (3 ms)** > [ RUN ] NetTest.ConstructMAC > [ OK ] NetTest.ConstructMAC (1 ms) > [ RUN ] NetTest.ParseMAC > [ OK ] NetTest.ParseMAC (1 ms) > [--] 8 tests from NetTest (19 ms total) > > > Thanks, > > Jeff Coffler > >
Re: Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59203/ --- (Updated May 11, 2017, 8:09 p.m.) Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-5938 https://issues.apache.org/jira/browse/MESOS-5938 Repository: mesos Description --- Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform. Diffs - 3rdparty/stout/tests/ip_tests.cpp 4c6f81bd53413360182b447ddb149a18e406870e 3rdparty/stout/tests/mac_tests.cpp d4560e75ae4e03d1765c599298e88842381690b9 Diff: https://reviews.apache.org/r/59203/diff/1/ Testing --- On Linux, did a 'make check' and insured that all tests (particularly stout tests, where the work was performed) passed. On Windows, did the rough equivalent. Here's relevant output from the Windows stout-tests.exe program: [--] 8 tests from NetTest **[ RUN ] NetTest.LinkDevice [ OK ] NetTest.LinkDevice (4 ms)** [ RUN ] NetTest.ConstructIPv4 [ OK ] NetTest.ConstructIPv4 (1 ms) [ RUN ] NetTest.ConstructIPv6 [ OK ] NetTest.ConstructIPv6 (0 ms) [ RUN ] NetTest.ConstructIPv4Network [ OK ] NetTest.ConstructIPv4Network (0 ms) [ RUN ] NetTest.ConstructIPv6Network [ OK ] NetTest.ConstructIPv6Network (0 ms) **[ RUN ] NetTest.Mac [ OK ] NetTest.Mac (3 ms)** [ RUN ] NetTest.ConstructMAC [ OK ] NetTest.ConstructMAC (1 ms) [ RUN ] NetTest.ParseMAC [ OK ] NetTest.ParseMAC (1 ms) [--] 8 tests from NetTest (19 ms total) Thanks, Jeff Coffler
Review Request 59203: Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59203/ --- Review request for mesos. Repository: mesos Description --- Enable NetTest.LinkDevice and NetTest.Mac tests on Windows platform. Diffs - 3rdparty/stout/tests/ip_tests.cpp 4c6f81bd53413360182b447ddb149a18e406870e 3rdparty/stout/tests/mac_tests.cpp d4560e75ae4e03d1765c599298e88842381690b9 Diff: https://reviews.apache.org/r/59203/diff/1/ Testing --- On Linux, did a 'make check' and insured that all tests (particularly stout tests, where the work was performed) passed. On Windows, did the rough equivalent. Here's relevant output from the Windows stout-tests.exe program: [--] 8 tests from NetTest **[ RUN ] NetTest.LinkDevice [ OK ] NetTest.LinkDevice (4 ms)** [ RUN ] NetTest.ConstructIPv4 [ OK ] NetTest.ConstructIPv4 (1 ms) [ RUN ] NetTest.ConstructIPv6 [ OK ] NetTest.ConstructIPv6 (0 ms) [ RUN ] NetTest.ConstructIPv4Network [ OK ] NetTest.ConstructIPv4Network (0 ms) [ RUN ] NetTest.ConstructIPv6Network [ OK ] NetTest.ConstructIPv6Network (0 ms) **[ RUN ] NetTest.Mac [ OK ] NetTest.Mac (3 ms)** [ RUN ] NetTest.ConstructMAC [ OK ] NetTest.ConstructMAC (1 ms) [ RUN ] NetTest.ParseMAC [ OK ] NetTest.ParseMAC (1 ms) [--] 8 tests from NetTest (19 ms total) Thanks, Jeff Coffler
