Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Andrew Schwartzmeyer]

> On May 26, 2017, 4:52 p.m., Zhitao Li wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 30 (patched)
> > 
> >
> > Can you explain how is these hashes geneareted and used?
> > 
> > I'm working on upgrading protobuf library to 3.3.0 so this hash would 
> > change, but I don't know how I can generate a correct value from here...
> 
> Joseph Wu wrote:
> You can use any SHA-generating utility to get these hashes, like:
> ```
> shasum -a 256 
> openssl sha -sha256 
> ```

Or even `Get-FileHash -Algorithm SHA256 ` in PowerShell ;)


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review176208
---


On May 24, 2017, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Joseph Wu]

> On May 26, 2017, 9:52 a.m., Zhitao Li wrote:
> > 3rdparty/cmake/Versions.cmake
> > Lines 30 (patched)
> > 
> >
> > Can you explain how is these hashes geneareted and used?
> > 
> > I'm working on upgrading protobuf library to 3.3.0 so this hash would 
> > change, but I don't know how I can generate a correct value from here...

You can use any SHA-generating utility to get these hashes, like:
```
shasum -a 256 
openssl sha -sha256 
```


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review176208
---


On May 24, 2017, 12:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 12:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review176208
---




3rdparty/cmake/Versions.cmake
Lines 30 (patched)


Can you explain how is these hashes geneareted and used?

I'm working on upgrading protobuf library to 3.3.0 so this hash would 
change, but I don't know how I can generate a correct value from here...


- Zhitao Li


On May 24, 2017, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review176133
---


Ship it!




Ship It!

- Joseph Wu


On May 24, 2017, 12:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 12:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review176117
---



Patch looks great!

Reviews applied: [59536]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 24, 2017, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review175985
---


Ship it!




Ship It!

- Aaron Wood


On May 24, 2017, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Andrew Schwartzmeyer]

> On May 24, 2017, 7:47 p.m., Aaron Wood wrote:
> > Are these hashes checked anywhere? I didn't seen anything that's verifying 
> > the hashes.

Yes, the `URL_HASH` argument to the `ExternalProject_Add` 
[macro](https://cmake.org/cmake/help/v3.8/module/ExternalProject.html) performs 
automatic verification given the hash for the URL.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review175979
---


On May 24, 2017, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Aaron Wood via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/#review175979
---



Are these hashes checked anywhere? I didn't seen anything that's verifying the 
hashes.

- Aaron Wood


On May 24, 2017, 7:13 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59536/
> ---
> 
> (Updated May 24, 2017, 7:13 p.m.)
> 
> 
> Review request for mesos, Aaron Wood and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `ExternalProject_Add` uses this hash to verify the tarballs
> automatically. This removes the following warning:
> 
> File will not be verified since no URL_HASH specified
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
>   3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 
> 
> 
> Diff: https://reviews.apache.org/r/59536/diff/1/
> 
> 
> Testing
> ---
> 
> make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
> Windows.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59536/
---

(Updated May 24, 2017, 7:13 p.m.)


Review request for mesos, Aaron Wood and Joseph Wu.


Summary (updated)
-

CMake: Added SHA256 hashes for 3rdparty downloads.


Repository: mesos


Description
---

The `ExternalProject_Add` uses this hash to verify the tarballs
automatically. This removes the following warning:

File will not be verified since no URL_HASH specified


Diffs
-

  3rdparty/CMakeLists.txt 03f314fdbb8216ca21abed3108e6986d037b2019 
  3rdparty/cmake/Versions.cmake d3f572c0b54fea4494fee033c549fa47c301 


Diff: https://reviews.apache.org/r/59536/diff/1/


Testing
---

make check on Linux, cmake --build . --target mesos-tests and stout-tests on 
Windows.


Thanks,

Andrew Schwartzmeyer