Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

2017-07-11 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
---

(Updated July 11, 2017, 5:14 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address review comment.


Bugs: MESOS-7612
https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
---

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs (updated)
-

  src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 
  src/tests/master_tests.cpp 9cfa510f1e5742b47a44cb640a0d6ba85a2880ae 


Diff: https://reviews.apache.org/r/59764/diff/5/

Changes: https://reviews.apache.org/r/59764/diff/4-5/


Testing
---

`make check`

Manual testing.


Thanks,

Neil Conway

Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

2017-07-10 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/#review180143
---


Fix it, then Ship it!





src/master/master.cpp
Lines 6090 (patched)


s/; to/. To/ ? to be consistent with the above comment?


- Vinod Kone


On July 5, 2017, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59764/
> ---
> 
> (Updated July 5, 2017, 10:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7612
> https://issues.apache.org/jira/browse/MESOS-7612
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We expect the master's domain to be configured first, then the domain of
> the agents to be configured. Therefore, if an agent with configured
> domain attempts to register or re-register with a master that does not
> have a configured domain, the registration attempt should be ignored.
> This is important, because the master would have no way of determining
> whether the agent is "remote" or not, which might result in placing
> inappropriate workloads on it.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56 
>   src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 
> 
> 
> Diff: https://reviews.apache.org/r/59764/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

2017-07-05 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
---

(Updated July 5, 2017, 10:32 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-7612
https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
---

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs (updated)
-

  src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56 
  src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f 


Diff: https://reviews.apache.org/r/59764/diff/4/

Changes: https://reviews.apache.org/r/59764/diff/3-4/


Testing
---

`make check`

Manual testing.


Thanks,

Neil Conway

Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

2017-06-05 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
---

(Updated June 5, 2017, 8:40 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Fix test.


Bugs: MESOS-7612
https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
---

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs (updated)
-

  src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 


Diff: https://reviews.apache.org/r/59764/diff/3/

Changes: https://reviews.apache.org/r/59764/diff/2-3/


Testing
---

`make check`

Manual testing.


Thanks,

Neil Conway

Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

2017-06-05 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
---

(Updated June 5, 2017, 6:29 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Improve tests.


Bugs: MESOS-7612
https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
---

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs (updated)
-

  src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 


Diff: https://reviews.apache.org/r/59764/diff/2/

Changes: https://reviews.apache.org/r/59764/diff/1-2/


Testing
---

`make check`

Manual testing.


Thanks,

Neil Conway

Review Request 59764: Ignore registration attempts by agents with misconfigured domain.

2017-06-02 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-7612
https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
---

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs
-

  src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 
  src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 


Diff: https://reviews.apache.org/r/59764/diff/1/


Testing
---

`make check`

Manual testing.


Thanks,

Neil Conway