Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

2017-06-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60069/
---

(Updated June 20, 2017, 12:16 a.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-7667
https://issues.apache.org/jira/browse/MESOS-7667


Repository: mesos


Description
---

Adjusted the master to the new resources format [10/N].


Diffs (updated)
-

  src/master/http.cpp 4f838493104146e1a6b68eb64d8ec122cd54b7f7 
  src/master/master.hpp 9c1e95c8ba4c649680c8b5dd3bf26aeea1cfcdc0 
  src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 
  src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
  src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce 


Diff: https://reviews.apache.org/r/60069/diff/8/

Changes: https://reviews.apache.org/r/60069/diff/7-8/


Testing
---


Thanks,

Michael Park

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

2017-06-20 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60069/#review178347
---




src/master/master.cpp
Line 3613 (original), 3638 (patched)


Fix this to account for both formats. We're not validated nor converted at 
this point.



src/master/master.cpp
Line 3665 (original), 3691 (patched)


Change this since we're not validated nor converted at this point.



src/master/master.cpp
Line 4165 (original), 4191 (patched)


We iterate by copy here



src/master/master.cpp
Lines 4787-4789 (original), 4867-4869 (patched)


Leave this alone.


- Michael Park


On June 19, 2017, 10:33 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60069/
> ---
> 
> (Updated June 19, 2017, 10:33 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7667
> https://issues.apache.org/jira/browse/MESOS-7667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted the master to the new resources format [10/N].
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f838493104146e1a6b68eb64d8ec122cd54b7f7 
>   src/master/master.hpp 9c1e95c8ba4c649680c8b5dd3bf26aeea1cfcdc0 
>   src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 
>   src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
>   src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce 
> 
> 
> Diff: https://reviews.apache.org/r/60069/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

2017-06-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60069/
---

(Updated June 19, 2017, 10:33 p.m.)


Review request for mesos and Neil Conway.


Bugs: MESOS-7667
https://issues.apache.org/jira/browse/MESOS-7667


Repository: mesos


Description
---

Adjusted the master to the new resources format [10/N].


Diffs (updated)
-

  src/master/http.cpp 4f838493104146e1a6b68eb64d8ec122cd54b7f7 
  src/master/master.hpp 9c1e95c8ba4c649680c8b5dd3bf26aeea1cfcdc0 
  src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 
  src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
  src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce 


Diff: https://reviews.apache.org/r/60069/diff/6/

Changes: https://reviews.apache.org/r/60069/diff/5-6/


Testing
---


Thanks,

Michael Park

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

2017-06-19 Thread Michael Park 


> On June 15, 2017, 1:32 a.m., Neil Conway wrote:
> > src/master/master.cpp
> > Line 3907 (original), 3907 (patched)
> > 
> >
> > Confused why this is in the same loop as `injectAllocationInfo`; 
> > updating the comment would help.

This was actually incorrect, as `convertResourceFormat` requires valid 
resources. This has been moved to be after `operation::validate` calls.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60069/#review177913
---


On June 14, 2017, 2:56 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60069/
> ---
> 
> (Updated June 14, 2017, 2:56 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7667
> https://issues.apache.org/jira/browse/MESOS-7667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adjusted the master to the new resources format [10/N].
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f838493104146e1a6b68eb64d8ec122cd54b7f7 
>   src/master/master.hpp 9c1e95c8ba4c649680c8b5dd3bf26aeea1cfcdc0 
>   src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 
>   src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
>   src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce 
> 
> 
> Diff: https://reviews.apache.org/r/60069/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

2017-06-19 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60069/#review178189
---


Ship it!




Ship It!

- Neil Conway


On June 14, 2017, 9:56 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60069/
> ---
> 
> (Updated June 14, 2017, 9:56 a.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-7667
> https://issues.apache.org/jira/browse/MESOS-7667
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 4f838493104146e1a6b68eb64d8ec122cd54b7f7 
>   src/master/master.hpp 9c1e95c8ba4c649680c8b5dd3bf26aeea1cfcdc0 
>   src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 
>   src/master/quota.cpp 3e0d280efff69904b74e5d4c71985ab44ffa34a7 
>   src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce 
> 
> 
> Diff: https://reviews.apache.org/r/60069/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>