Re: Review Request 60175: Introduced a utility function `Resources::hasRefinedReservations`.

2017-06-18 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60175/#review178164
---


Ship it!




Is it worth adding coverage of this to the tests?

- Neil Conway


On June 18, 2017, 10:03 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60175/
> ---
> 
> (Updated June 18, 2017, 10:03 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp d380a590404f119cdb1f715c43bbb0052422d1ec 
>   include/mesos/v1/resources.hpp 66c2b215761c488a1554f925726d53035d40708a 
>   src/common/resources.cpp f12ab970fbce2815a5a22e5080af9fb70c6aef9f 
>   src/v1/resources.cpp 30644ee0bfeb8498d7b10daa79c0da369201abf3 
> 
> 
> Diff: https://reviews.apache.org/r/60175/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>



Review Request 60175: Introduced a utility function `Resources::hasRefinedReservations`.

2017-06-18 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60175/
---

Review request for mesos and Neil Conway.


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/resources.hpp d380a590404f119cdb1f715c43bbb0052422d1ec 
  include/mesos/v1/resources.hpp 66c2b215761c488a1554f925726d53035d40708a 
  src/common/resources.cpp f12ab970fbce2815a5a22e5080af9fb70c6aef9f 
  src/v1/resources.cpp 30644ee0bfeb8498d7b10daa79c0da369201abf3 


Diff: https://reviews.apache.org/r/60175/diff/1/


Testing
---


Thanks,

Michael Park