Re: Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60292/#review179039 --- Ship it! Note: There are a few minor whitespace nits scattered throughout this chain. I'll deal with them before committing. - Joseph Wu On June 21, 2017, 2:53 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60292/ > --- > > (Updated June 21, 2017, 2:53 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, > Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6817, MESOS-7371 and MESOS-7407 > https://issues.apache.org/jira/browse/MESOS-6817 > https://issues.apache.org/jira/browse/MESOS-7371 > https://issues.apache.org/jira/browse/MESOS-7407 > > > Repository: mesos > > > Description > --- > > When dealing with Windows APIs, often `string` -> `wstring` conversions > are required. This addition makes the process cleaner. > > Also added explicit errors messages, which are written to the buffer > instead of throwing an exception if an error occurs. > > > Diffs > - > > 3rdparty/stout/include/stout/stringify.hpp > 44da506e5eb3c04f6727683ccc346e08f128d265 > > > Diff: https://reviews.apache.org/r/60292/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60292/ --- (Updated June 21, 2017, 9:53 p.m.) Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park. Bugs: MESOS-6817, MESOS-7371 and MESOS-7407 https://issues.apache.org/jira/browse/MESOS-6817 https://issues.apache.org/jira/browse/MESOS-7371 https://issues.apache.org/jira/browse/MESOS-7407 Repository: mesos Description --- When dealing with Windows APIs, often `string` -> `wstring` conversions are required. This addition makes the process cleaner. Also added explicit errors messages, which are written to the buffer instead of throwing an exception if an error occurs. Diffs - 3rdparty/stout/include/stout/stringify.hpp 44da506e5eb3c04f6727683ccc346e08f128d265 Diff: https://reviews.apache.org/r/60292/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
Review Request 60292: Windows: Added a `wstring wide_stringify(string)` helper.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60292/ --- Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park. Bugs: MESOS-6817, MESOS-7371 and MESOS-7407 https://issues.apache.org/jira/browse/MESOS-6817 https://issues.apache.org/jira/browse/MESOS-7371 https://issues.apache.org/jira/browse/MESOS-7407 Repository: mesos Description --- When dealing with Windows APIs, often `string` -> `wstring` conversions are required. This addition makes the process cleaner. Also added explicit errors messages, which are written to the buffer instead of throwing an exception if an error occurs. Diffs - 3rdparty/stout/include/stout/stringify.hpp 44da506e5eb3c04f6727683ccc346e08f128d265 Diff: https://reviews.apache.org/r/60292/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
