Re: Review Request 60300: Windows: Fixed `isdir()` and `isfile()` to support long paths.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60300/#review179682
---


Ship it!





3rdparty/stout/include/stout/os/windows/stat.hpp
Line 75 (original), 79 (patched)


This flag negation is enough to warrant a note for the Posix folks reading 
this code.
```
  // NOTE: Windows files attributes do not define a flag for "regular"
  // files. Instead, this call will only return successfully iff the
  // given file or directory exists. Checking against the directory
  // flag determines if the path is a file or directory.
```


- Joseph Wu


On June 21, 2017, 2:57 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60300/
> ---
> 
> (Updated June 21, 2017, 2:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, 
> Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
> https://issues.apache.org/jira/browse/MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-7371
> https://issues.apache.org/jira/browse/MESOS-7407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now uses Windows file attributes instead of `::_stat()`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 
> b2ff43696a6b4172a2ebcf08ae36aa9e143ad101 
> 
> 
> Diff: https://reviews.apache.org/r/60300/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 60300: Windows: Fixed `isdir()` and `isfile()` to support long paths.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60300/
---

Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, 
Joseph Wu, Li Li, and Michael Park.


Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
https://issues.apache.org/jira/browse/MESOS-6817
https://issues.apache.org/jira/browse/MESOS-7371
https://issues.apache.org/jira/browse/MESOS-7407


Repository: mesos


Description
---

Now uses Windows file attributes instead of `::_stat()`.


Diffs
-

  3rdparty/stout/include/stout/os/windows/stat.hpp 
b2ff43696a6b4172a2ebcf08ae36aa9e143ad101 


Diff: https://reviews.apache.org/r/60300/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer