Re: Review Request 60308: Refactored `enum FollowSymlink` to an `enum class FollowSymlink`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60308/#review179907
---


Ship it!




I'll tweak the below.


3rdparty/stout/include/stout/os/windows/stat.hpp
Lines 37 (patched)


This shouldn't be necessary, since `windows/stat.hpp` depends on 
`reparsepoint.hpp` which defines the `enum class ...`.



3rdparty/stout/tests/os_tests.cpp
Lines 218 (patched)


Let's just keep this at the top by all the other `using ...` statements.



3rdparty/stout/tests/os_tests.cpp
Line 759 (original), 763 (patched)


Ditto here.


- Joseph Wu


On June 21, 2017, 2:59 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60308/
> ---
> 
> (Updated June 21, 2017, 2:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, 
> Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
> https://issues.apache.org/jira/browse/MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-7371
> https://issues.apache.org/jira/browse/MESOS-7407
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using `enum class` is preferred as it provides stronger type-safety.
> 
> The `enum class FollowSymlink` definition was duplicated into
> the POSIX and Windows `stat.hpp` headers to avoid a circular
> dependency otherwise caused by `reparsepoint.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
> a9228437bc1b2b287dd19cb9903ce048db2a90ef 
>   3rdparty/stout/include/stout/os/posix/stat.hpp 
> 2762c41fdebc28c412126e39029cd03345677a73 
>   3rdparty/stout/include/stout/os/stat.hpp 
> d002c98ac3afbcdc8886a8ba6657919d011f2b46 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 
> b2ff43696a6b4172a2ebcf08ae36aa9e143ad101 
>   3rdparty/stout/tests/os_tests.cpp 7f785b07feaed28e272b4195362eb83842813e2b 
> 
> 
> Diff: https://reviews.apache.org/r/60308/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 60308: Refactored `enum FollowSymlink` to an `enum class FollowSymlink`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60308/
---

Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, 
Joseph Wu, Li Li, and Michael Park.


Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
https://issues.apache.org/jira/browse/MESOS-6817
https://issues.apache.org/jira/browse/MESOS-7371
https://issues.apache.org/jira/browse/MESOS-7407


Repository: mesos


Description
---

Using `enum class` is preferred as it provides stronger type-safety.

The `enum class FollowSymlink` definition was duplicated into
the POSIX and Windows `stat.hpp` headers to avoid a circular
dependency otherwise caused by `reparsepoint.hpp`.


Diffs
-

  3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp 
a9228437bc1b2b287dd19cb9903ce048db2a90ef 
  3rdparty/stout/include/stout/os/posix/stat.hpp 
2762c41fdebc28c412126e39029cd03345677a73 
  3rdparty/stout/include/stout/os/stat.hpp 
d002c98ac3afbcdc8886a8ba6657919d011f2b46 
  3rdparty/stout/include/stout/os/windows/stat.hpp 
b2ff43696a6b4172a2ebcf08ae36aa9e143ad101 
  3rdparty/stout/tests/os_tests.cpp 7f785b07feaed28e272b4195362eb83842813e2b 


Diff: https://reviews.apache.org/r/60308/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer